mbox series

[net-next,0/3] tcp_mmap: optmizations

Message ID 20200820171118.1822853-1-edumazet@google.com
Headers show
Series tcp_mmap: optmizations | expand

Message

Eric Dumazet Aug. 20, 2020, 5:11 p.m. UTC 
This series updates tcp_mmap reference tool to use best pratices.

First patch is using madvise(MADV_DONTNEED) to decrease pressure
on the socket lock.

Last patches try to use huge pages when available.

Eric Dumazet (3):
  selftests: net: tcp_mmap: use madvise(MADV_DONTNEED)
  selftests: net: tcp_mmap: Use huge pages in send path
  selftests: net: tcp_mmap: Use huge pages in receive path

 tools/testing/selftests/net/tcp_mmap.c | 42 +++++++++++++++++++++-----
 1 file changed, 35 insertions(+), 7 deletions(-)

Comments

Soheil Hassas Yeganeh Aug. 20, 2020, 5:31 p.m. UTC | #1 
On Thu, Aug 20, 2020 at 1:11 PM Eric Dumazet <edumazet@google.com> wrote:
>
> This series updates tcp_mmap reference tool to use best pratices.
>
> First patch is using madvise(MADV_DONTNEED) to decrease pressure
> on the socket lock.
>
> Last patches try to use huge pages when available.
>
> Eric Dumazet (3):
>   selftests: net: tcp_mmap: use madvise(MADV_DONTNEED)
>   selftests: net: tcp_mmap: Use huge pages in send path
>   selftests: net: tcp_mmap: Use huge pages in receive path

Acked-by: Soheil Hassas Yeganeh <soheil@google.com>

Thank you for the patches!

>  tools/testing/selftests/net/tcp_mmap.c | 42 +++++++++++++++++++++-----
>  1 file changed, 35 insertions(+), 7 deletions(-)
>
> --
> 2.28.0.297.g1956fa8f8d-goog
>
Arjun Roy Aug. 20, 2020, 5:37 p.m. UTC | #2 
On Thu, Aug 20, 2020 at 10:32 AM Soheil Hassas Yeganeh
<soheil@google.com> wrote:
>
> On Thu, Aug 20, 2020 at 1:11 PM Eric Dumazet <edumazet@google.com> wrote:
> >
> > This series updates tcp_mmap reference tool to use best pratices.
> >
> > First patch is using madvise(MADV_DONTNEED) to decrease pressure
> > on the socket lock.
> >
> > Last patches try to use huge pages when available.
> >
> > Eric Dumazet (3):
> >   selftests: net: tcp_mmap: use madvise(MADV_DONTNEED)
> >   selftests: net: tcp_mmap: Use huge pages in send path
> >   selftests: net: tcp_mmap: Use huge pages in receive path
>
> Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
>
> Thank you for the patches!
>

Acked-by: Arjun Roy <arjunroy@google.com>

-Arjun

> >  tools/testing/selftests/net/tcp_mmap.c | 42 +++++++++++++++++++++-----
> >  1 file changed, 35 insertions(+), 7 deletions(-)
> >
> > --
> > 2.28.0.297.g1956fa8f8d-goog
> >
David Miller Aug. 20, 2020, 11:15 p.m. UTC | #3 
From: Eric Dumazet <edumazet@google.com>
Date: Thu, 20 Aug 2020 10:11:15 -0700

> This series updates tcp_mmap reference tool to use best pratices.
> 
> First patch is using madvise(MADV_DONTNEED) to decrease pressure
> on the socket lock.
> 
> Last patches try to use huge pages when available.

Series applied, thanks Eric.