| Message ID | 20200816194316.2291489-1-andrew@lunn.ch |
|---|---|
| Headers | show |
| Series | net: dsa: mv88e6xxx: Add devlink regions support | expand |
I tested this on the Rev C Zii Vybrid Dev Board which has two Marvell 88E6390X switches. Both switches worth of port, global, and atu data show up when running the devlink show command and for each of the regions, I can dump the contents. I also tested on a different platform with a single 88E6352. Full series is: Tested-by: Chris Healy <cphealy@gmail.com> On Sun, Aug 16, 2020 at 12:44 PM Andrew Lunn <andrew@lunn.ch> wrote: > > Make use of devlink regions to allow read access to some of the > internal of the switches. The switch itself will never trigger a > region snapshot, it is assumed it is performed from user space as > needed. > > Andrew Lunn (7): > net: dsa: Add helper to convert from devlink to ds > net: dsa: Add devlink regions support to DSA > net: dsa: mv88e6xxx: Move devlink code into its own file > net: dsa: mv88e6xxx: Create helper for FIDs in use > net: dsa: mv88e6xxx: Add devlink regions > net: dsa: wire up devlink info get > net: dsa: mv88e6xxx: Implement devlink info get callback > > drivers/net/dsa/mv88e6xxx/Makefile | 1 + > drivers/net/dsa/mv88e6xxx/chip.c | 290 ++---------- > drivers/net/dsa/mv88e6xxx/chip.h | 14 + > drivers/net/dsa/mv88e6xxx/devlink.c | 690 ++++++++++++++++++++++++++++ > drivers/net/dsa/mv88e6xxx/devlink.h | 21 + > include/net/dsa.h | 13 +- > net/dsa/dsa.c | 36 +- > net/dsa/dsa2.c | 21 +- > 8 files changed, 813 insertions(+), 273 deletions(-) > create mode 100644 drivers/net/dsa/mv88e6xxx/devlink.c > create mode 100644 drivers/net/dsa/mv88e6xxx/devlink.h > > -- > 2.28.0 >
On 8/16/20 12:43 PM, Andrew Lunn wrote: > Make use of devlink regions to allow read access to some of the > internal of the switches. The switch itself will never trigger a > region snapshot, it is assumed it is performed from user space as > needed. > > Andrew Lunn (7): > net: dsa: Add helper to convert from devlink to ds > net: dsa: Add devlink regions support to DSA > net: dsa: mv88e6xxx: Move devlink code into its own file > net: dsa: mv88e6xxx: Create helper for FIDs in use > net: dsa: mv88e6xxx: Add devlink regions > net: dsa: wire up devlink info get > net: dsa: mv88e6xxx: Implement devlink info get callback Andrew, do you mind copying all DSA maintainers on this patch series since it potentially affects other drivers given the standard representation you want to see adopted? Thanks
On Mon, Aug 17, 2020 at 10:08:07AM -0700, Florian Fainelli wrote: > On 8/16/20 12:43 PM, Andrew Lunn wrote: > > Make use of devlink regions to allow read access to some of the > > internal of the switches. The switch itself will never trigger a > > region snapshot, it is assumed it is performed from user space as > > needed. > > > > Andrew Lunn (7): > > net: dsa: Add helper to convert from devlink to ds > > net: dsa: Add devlink regions support to DSA > > net: dsa: mv88e6xxx: Move devlink code into its own file > > net: dsa: mv88e6xxx: Create helper for FIDs in use > > net: dsa: mv88e6xxx: Add devlink regions > > net: dsa: wire up devlink info get > > net: dsa: mv88e6xxx: Implement devlink info get callback > > Andrew, do you mind copying all DSA maintainers on this patch series > since it potentially affects other drivers given the standard > representation you want to see adopted? Hi Florian I'm not proposing anything standard at all here. This is all specific to the mv88e6xxx. As i pointed out to Vladimir, devlink regions are supposed to be very device or driver specific. Andrew