[net-next,0/6,pull,request] 40GbE Intel Wired LAN Driver Updates 2020-07-28

This series contains updates to i40e driver only.

Li RongQing removes binding affinity mask to a fixed CPU and sets
prefetch of Rx buffer page to occur conditionally.

Björn provides AF_XDP performance improvements by not prefetching HW
descriptors, using 16 byte descriptors, increasing budget for AF_XDP
receive, and moving buffer allocation out of Rx processing loop.

The following are changes since commit 5e619d73e6797ed9f2554a1bf996d52d8c91ca50:
  net/mlx4: Use fallthrough pseudo-keyword
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 40GbE

Björn Töpel (4):
  i40e, xsk: remove HW descriptor prefetch in AF_XDP path
  i40e: use 16B HW descriptors instead of 32B
  i40e, xsk: increase budget for AF_XDP path
  i40e, xsk: move buffer allocation out of the Rx processing loop

Li RongQing (2):
  i40e: not compute affinity_mask for IRQ
  i40e: prefetch struct page of Rx buffer conditionally

 drivers/net/ethernet/intel/i40e/i40e.h        |  2 +-
 .../net/ethernet/intel/i40e/i40e_debugfs.c    | 10 +++----
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 16 ++++-------
 drivers/net/ethernet/intel/i40e/i40e_trace.h  |  6 ++--
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   | 21 ++++++++++++--
 drivers/net/ethernet/intel/i40e/i40e_txrx.h   |  2 +-
 .../ethernet/intel/i40e/i40e_txrx_common.h    | 13 ---------
 drivers/net/ethernet/intel/i40e/i40e_type.h   |  5 +++-
 drivers/net/ethernet/intel/i40e/i40e_xsk.c    | 28 +++++++++++++------
 9 files changed, 55 insertions(+), 48 deletions(-)

On Tue, 28 Jul 2020 12:08:36 -0700 Tony Nguyen wrote:
> This series contains updates to i40e driver only.
> 
> Li RongQing removes binding affinity mask to a fixed CPU and sets
> prefetch of Rx buffer page to occur conditionally.
> 
> Björn provides AF_XDP performance improvements by not prefetching HW
> descriptors, using 16 byte descriptors, increasing budget for AF_XDP
> receive, and moving buffer allocation out of Rx processing loop.

My comment on patch #2 is really a nit, but for patch 5 I think we
should consider carefully a common path rather than "tweak" the drivers
like this.

On Tue, 28 Jul 2020 at 22:20, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 28 Jul 2020 12:08:36 -0700 Tony Nguyen wrote:
> > This series contains updates to i40e driver only.
> >
> > Li RongQing removes binding affinity mask to a fixed CPU and sets
> > prefetch of Rx buffer page to occur conditionally.
> >
> > Björn provides AF_XDP performance improvements by not prefetching HW
> > descriptors, using 16 byte descriptors, increasing budget for AF_XDP
> > receive, and moving buffer allocation out of Rx processing loop.
>
> My comment on patch #2 is really a nit, but for patch 5 I think we
> should consider carefully a common path rather than "tweak" the drivers
> like this.

Yup, I agree that tweaks like this should be avoided, and I said that
I'll address it in a follow up. However, I was under the impression
that this series would still be pulled (discussed in patch 5), but I
can't find it in the tree.

Thanks,
Björn

On Mon, 10 Aug 2020 at 13:47, Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> On Tue, 28 Jul 2020 at 22:20, Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue, 28 Jul 2020 12:08:36 -0700 Tony Nguyen wrote:
> > > This series contains updates to i40e driver only.
> > >
> > > Li RongQing removes binding affinity mask to a fixed CPU and sets
> > > prefetch of Rx buffer page to occur conditionally.
> > >
> > > Björn provides AF_XDP performance improvements by not prefetching HW
> > > descriptors, using 16 byte descriptors, increasing budget for AF_XDP
> > > receive, and moving buffer allocation out of Rx processing loop.
> >
> > My comment on patch #2 is really a nit, but for patch 5 I think we
> > should consider carefully a common path rather than "tweak" the drivers
> > like this.
>
> Yup, I agree that tweaks like this should be avoided, and I said that
> I'll address it in a follow up. However, I was under the impression
> that this series would still be pulled (discussed in patch 5), but I
> can't find it in the tree.
>

Ugh. Please ignore the noise. Patchwork says "Changes Requested".

I'll rework the series!


Cheers,
Björn