| Message ID | 1596599425-5534-1-git-send-email-zhangchangzhong@huawei.com |
|---|---|
| Headers | show |
| Series | support multipacket broadcast message | expand |
Hello, Thank you for your patches! Currently I'm busy, but I'll take a look at it as soon possible. btw. can you tell me about more of your use case/work. I would like to have some feedback about this stack. You can write a personal message, if it is not for public. On Wed, Aug 05, 2020 at 11:50:21AM +0800, Zhang Changzhong wrote: > Zhang Changzhong (4): > can: j1939: fix support for multipacket broadcast message > can: j1939: cancel rxtimer on multipacket broadcast session complete > can: j1939: abort multipacket broadcast session when timeout occurs > can: j1939: add rxtimer for multipacket broadcast session > > net/can/j1939/transport.c | 48 +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 36 insertions(+), 12 deletions(-) Regards, Oleksij
Hi Oleksij, We have tested this j1939 stack according to SAE J1939-21. It works fine for most cases, but when we test multipacket broadcast message function we found the receiver can't receive those packets. You can reproduce on CAN bus or vcan, for vcan case use cangw to connect vcan0 and vcan1: sudo cangw -A -s vcan0 -d vcan1 -e sudo cangw -A -s vcan1 -d vcan0 -e To reproduce it use following commands: testj1939 -B -r vcan1:0x90 & testj1939 -B -s20 vcan0:0x80 :,0x12300 Besides, candump receives correct packets while testj1939 receives nothing. Regards, Zhang Changzhong On 2020/8/7 0:10, Oleksij Rempel wrote: > Hello, > > Thank you for your patches! Currently I'm busy, but I'll take a look at it as > soon possible. > > btw. can you tell me about more of your use case/work. I would like to > have some feedback about this stack. You can write a personal message, > if it is not for public. > > On Wed, Aug 05, 2020 at 11:50:21AM +0800, Zhang Changzhong wrote: >> Zhang Changzhong (4): >> can: j1939: fix support for multipacket broadcast message >> can: j1939: cancel rxtimer on multipacket broadcast session complete >> can: j1939: abort multipacket broadcast session when timeout occurs >> can: j1939: add rxtimer for multipacket broadcast session >> >> net/can/j1939/transport.c | 48 +++++++++++++++++++++++++++++++++++------------ >> 1 file changed, 36 insertions(+), 12 deletions(-) > > Regards, > Oleksij >
On Fri, Aug 07, 2020 at 05:36:38PM +0800, Zhang Changzhong wrote: > Hi Oleksij, > > We have tested this j1939 stack according to SAE J1939-21. It works fine for > most cases, but when we test multipacket broadcast message function we found > the receiver can't receive those packets. > > You can reproduce on CAN bus or vcan, for vcan case use cangw to connect vcan0 > and vcan1: > sudo cangw -A -s vcan0 -d vcan1 -e > sudo cangw -A -s vcan1 -d vcan0 -e > > To reproduce it use following commands: > testj1939 -B -r vcan1:0x90 & > testj1939 -B -s20 vcan0:0x80 :,0x12300 > > Besides, candump receives correct packets while testj1939 receives nothing. Ok, thank you! i'm able to reproduce it and added following test: https://github.com/linux-can/can-tests/blob/master/j1939/j1939_ac_1k_bam_local0.sh
Hello, On Wed, Aug 05, 2020 at 11:50:21AM +0800, Zhang Changzhong wrote: > Zhang Changzhong (4): > can: j1939: fix support for multipacket broadcast message > can: j1939: cancel rxtimer on multipacket broadcast session complete > can: j1939: abort multipacket broadcast session when timeout occurs > can: j1939: add rxtimer for multipacket broadcast session > > net/can/j1939/transport.c | 48 +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 36 insertions(+), 12 deletions(-) Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you for your work! Regards, Oleksij