| Message ID | 20200806155225.637202-1-sdf@google.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf] bpf: add missing return to resolve_btfids | expand |
On 08/06, Stanislav Fomichev wrote: > int sets_patch(struct object *obj) doesn't have a 'return 0' at the end. > Signed-off-by: Stanislav Fomichev <sdf@google.com> > --- > tools/bpf/resolve_btfids/main.c | 1 + > 1 file changed, 1 insertion(+) > diff --git a/tools/bpf/resolve_btfids/main.c > b/tools/bpf/resolve_btfids/main.c > index 52d883325a23..4d9ecb975862 100644 > --- a/tools/bpf/resolve_btfids/main.c > +++ b/tools/bpf/resolve_btfids/main.c > @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj) > next = rb_next(next); > } > + return 0; > } > static int symbols_patch(struct object *obj) > -- > 2.28.0.236.gb10cc79966-goog Sorry, forgot: Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
On Thu, Aug 6, 2020 at 11:22 AM <sdf@google.com> wrote: > > On 08/06, Stanislav Fomichev wrote: > > int sets_patch(struct object *obj) doesn't have a 'return 0' at the end. > > > Signed-off-by: Stanislav Fomichev <sdf@google.com> > > --- > > tools/bpf/resolve_btfids/main.c | 1 + > > 1 file changed, 1 insertion(+) > > > diff --git a/tools/bpf/resolve_btfids/main.c > > b/tools/bpf/resolve_btfids/main.c > > index 52d883325a23..4d9ecb975862 100644 > > --- a/tools/bpf/resolve_btfids/main.c > > +++ b/tools/bpf/resolve_btfids/main.c > > @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj) > > > next = rb_next(next); > > } > > + return 0; > > } > > > static int symbols_patch(struct object *obj) > > -- > > 2.28.0.236.gb10cc79966-goog > > Sorry, forgot: > > Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in > ELF object") Applied. Thanks
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c index 52d883325a23..4d9ecb975862 100644 --- a/tools/bpf/resolve_btfids/main.c +++ b/tools/bpf/resolve_btfids/main.c @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj) next = rb_next(next); } + return 0; } static int symbols_patch(struct object *obj)
int sets_patch(struct object *obj) doesn't have a 'return 0' at the end. Signed-off-by: Stanislav Fomichev <sdf@google.com> --- tools/bpf/resolve_btfids/main.c | 1 + 1 file changed, 1 insertion(+)