| Message ID | 20200730195749.4922-3-bruno.thomsen@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | Improve MDIO Ethernet PHY reset | expand |
On Thu, Jul 30, 2020 at 09:57:47PM +0200, Bruno Thomsen wrote: > MDIO bus reset pulse width is created by using udelay() > and that function might not be optimal depending on > device tree value. By switching to the new fsleep() helper > the correct delay function is called depending on > delay length, e.g. udelay(), usleep_range() or msleep(). > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 7/30/2020 12:57 PM, Bruno Thomsen wrote: > MDIO bus reset pulse width is created by using udelay() > and that function might not be optimal depending on > device tree value. By switching to the new fsleep() helper > the correct delay function is called depending on > delay length, e.g. udelay(), usleep_range() or msleep(). > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 46b33701ad4b..5df3782b05b4 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -554,7 +554,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner) bus->reset_gpiod = gpiod; gpiod_set_value_cansleep(gpiod, 1); - udelay(bus->reset_delay_us); + fsleep(bus->reset_delay_us); gpiod_set_value_cansleep(gpiod, 0); }
MDIO bus reset pulse width is created by using udelay() and that function might not be optimal depending on device tree value. By switching to the new fsleep() helper the correct delay function is called depending on delay length, e.g. udelay(), usleep_range() or msleep(). Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)