mbox series

[SRU,F/Unstable/OEM-5.6,0/1] Fix right speaker of HP laptop

Message ID 20200729083203.8118-1-kai.heng.feng@canonical.com
Headers show
Series Fix right speaker of HP laptop | expand

Message

Kai-Heng Feng July 29, 2020, 8:32 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1889375

[Impact]
Right speaker on an HP laptop doesn't work.

[Fix]
Correctly enable the AMP to drive the right speaker.

[Test]
Open Gnome Control Center to test the right channel.
I can hear the "front right" voice from the right speaker.

[Regression Potential]
Low. It's only affect a platform which is not on the market yet.

Kai-Heng Feng (1):
  UBUNTU: SAUCE: hda/realtek: Fix right speaker of HP laptop

 sound/pci/hda/patch_realtek.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

Comments

Timo Aaltonen July 29, 2020, 12:20 p.m. UTC | #1 
On 29.7.2020 11.32, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1889375
> 
> [Impact]
> Right speaker on an HP laptop doesn't work.
> 
> [Fix]
> Correctly enable the AMP to drive the right speaker.
> 
> [Test]
> Open Gnome Control Center to test the right channel.
> I can hear the "front right" voice from the right speaker.
> 
> [Regression Potential]
> Low. It's only affect a platform which is not on the market yet.
> 
> Kai-Heng Feng (1):
>   UBUNTU: SAUCE: hda/realtek: Fix right speaker of HP laptop
> 
>  sound/pci/hda/patch_realtek.c | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 

seems legit, applied to oem-5.6, thanks
Seth Forshee July 29, 2020, 9:40 p.m. UTC | #2 
On Wed, Jul 29, 2020 at 04:32:01PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1889375
> 
> [Impact]
> Right speaker on an HP laptop doesn't work.
> 
> [Fix]
> Correctly enable the AMP to drive the right speaker.
> 
> [Test]
> Open Gnome Control Center to test the right channel.
> I can hear the "front right" voice from the right speaker.
> 
> [Regression Potential]
> Low. It's only affect a platform which is not on the market yet.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to groovy/master-next, thanks!
Khalid Elmously Aug. 7, 2020, 9:35 p.m. UTC | #3 
Applied already by Kelsey

On 2020-07-29 16:32:01 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1889375
> 
> [Impact]
> Right speaker on an HP laptop doesn't work.
> 
> [Fix]
> Correctly enable the AMP to drive the right speaker.
> 
> [Test]
> Open Gnome Control Center to test the right channel.
> I can hear the "front right" voice from the right speaker.
> 
> [Regression Potential]
> Low. It's only affect a platform which is not on the market yet.
> 
> Kai-Heng Feng (1):
>   UBUNTU: SAUCE: hda/realtek: Fix right speaker of HP laptop
> 
>  sound/pci/hda/patch_realtek.c | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team