mbox series

[bpf-next,0/2] tools: bpftool: update prog names list and fix segfault

Message ID 20200724090618.16378-1-quentin@isovalent.com
Headers show
Series tools: bpftool: update prog names list and fix segfault | expand

Message

Quentin Monnet July 24, 2020, 9:06 a.m. UTC 
Although probing features with bpftool works fine if bpftool's array of
program and map type names lack the latest kernel additions, it can crash
if there are some types missing _in the middle_ of the arrays. The case
recently occurred with the addition of the "sk_lookup" name, which skipped
the "lsm" in the list.

Let's update the list, and let's make sure it does not crash bpftool again
if we omit other types again in the future.

Quentin Monnet (2):
  tools: bpftool: skip type probe if name is not found
  tools: bpftool: add LSM type to array of prog names

 tools/bpf/bpftool/feature.c | 8 ++++++++
 tools/bpf/bpftool/prog.c    | 1 +
 2 files changed, 9 insertions(+)

Comments

Daniel Borkmann July 28, 2020, 10:16 a.m. UTC | #1 
On 7/24/20 11:06 AM, Quentin Monnet wrote:
> Although probing features with bpftool works fine if bpftool's array of
> program and map type names lack the latest kernel additions, it can crash
> if there are some types missing _in the middle_ of the arrays. The case
> recently occurred with the addition of the "sk_lookup" name, which skipped
> the "lsm" in the list.
> 
> Let's update the list, and let's make sure it does not crash bpftool again
> if we omit other types again in the future.
> 
> Quentin Monnet (2):
>    tools: bpftool: skip type probe if name is not found
>    tools: bpftool: add LSM type to array of prog names
> 
>   tools/bpf/bpftool/feature.c | 8 ++++++++
>   tools/bpf/bpftool/prog.c    | 1 +
>   2 files changed, 9 insertions(+)
> 

Applied, thanks!