mbox series

[net-next,00/10] bnxt_en update.

Message ID 1595820586-2203-1-git-send-email-michael.chan@broadcom.com
Headers show
Series bnxt_en update. | expand

Message

Michael Chan July 27, 2020, 3:29 a.m. UTC 
This patchset removes the PCIe histogram and other debug register
data from ethtool -S. The removed data are not counters and they have
very large and constantly fluctuating values that are not suitable for
the ethtool -S decimal counter display.

The rest of the patches implement counter rollover for all hardware
counters that are not 64-bit counters.  Different generations of
hardware have different counter widths.  The driver will now query
the counter widths of all counters from firmware and implement
rollover support on all non-64-bit counters.

The last patch adds the PCIe histogram and other PCIe register data back
using the ethtool -d interface.

Michael Chan (8):
  bnxt_en: Update firmware interface to 1.10.1.54.
  bnxt_en: Use macros to define port statistics size and offset.
  bnxt_en: Refactor statistics code and structures.
  bnxt_en: Allocate additional memory for all statistics blocks.
  bnxt_en: Retrieve hardware counter masks from firmware if available.
  bnxt_en: Retrieve hardware masks for port counters.
  bnxt_en: Accumulate all counters.
  bnxt_en: Switch over to use the 64-bit software accumulated counters.

Vasundhara Volam (2):
  bnxt_en: Remove PCIe non-counters from ethtool statistics
  bnxt_en: Add support for 'ethtool -d'

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 494 ++++++++++++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  96 ++++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c     |   2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 138 +++---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h |   2 +
 drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h     | 468 ++++++++++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c   |   2 +-
 7 files changed, 860 insertions(+), 342 deletions(-)

Comments

David Miller July 27, 2020, 6:36 p.m. UTC | #1 
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 26 Jul 2020 23:29:36 -0400

> This patchset removes the PCIe histogram and other debug register
> data from ethtool -S. The removed data are not counters and they have
> very large and constantly fluctuating values that are not suitable for
> the ethtool -S decimal counter display.
> 
> The rest of the patches implement counter rollover for all hardware
> counters that are not 64-bit counters.  Different generations of
> hardware have different counter widths.  The driver will now query
> the counter widths of all counters from firmware and implement
> rollover support on all non-64-bit counters.
> 
> The last patch adds the PCIe histogram and other PCIe register data back
> using the ethtool -d interface.

I guess you missed the necessary infiniband driver updates necessary
with the firmware interface changes?
Michael Chan July 27, 2020, 6:42 p.m. UTC | #2 
On Mon, Jul 27, 2020 at 11:36 AM David Miller <davem@davemloft.net> wrote:
>
> From: Michael Chan <michael.chan@broadcom.com>
> Date: Sun, 26 Jul 2020 23:29:36 -0400
>
> > This patchset removes the PCIe histogram and other debug register
> > data from ethtool -S. The removed data are not counters and they have
> > very large and constantly fluctuating values that are not suitable for
> > the ethtool -S decimal counter display.
> >
> > The rest of the patches implement counter rollover for all hardware
> > counters that are not 64-bit counters.  Different generations of
> > hardware have different counter widths.  The driver will now query
> > the counter widths of all counters from firmware and implement
> > rollover support on all non-64-bit counters.
> >
> > The last patch adds the PCIe histogram and other PCIe register data back
> > using the ethtool -d interface.
>
> I guess you missed the necessary infiniband driver updates necessary
> with the firmware interface changes?

Yes, I missed it in v1, but v2 that I sent out afterwards has fixed it.  Thanks.