mbox series

[net-next,0/9] l2tp: avoid multiple assignment, remove BUG_ON

Message ID 20200724153157.9366-1-tparkin@katalix.com
Headers show
Series l2tp: avoid multiple assignment, remove BUG_ON | expand

Message

Tom Parkin July 24, 2020, 3:31 p.m. UTC 
l2tp hasn't been kept up to date with the static analysis checks offered
by checkpatch.pl.

This patchset builds on the series: "l2tp: cleanup checkpatch.pl
warnings" and "l2tp: further checkpatch.pl cleanups" to resolve some of
the remaining checkpatch warnings in l2tp.

Tom Parkin (9):
  l2tp: avoid multiple assignments
  l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start
  l2tp: remove BUG_ON in l2tp_session_queue_purge
  l2tp: remove BUG_ON in l2tp_tunnel_closeall
  l2tp: don't BUG_ON session magic checks in l2tp_ppp
  l2tp: don't BUG_ON seqfile checks in l2tp_ppp
  l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge
  l2tp: remove BUG_ON refcount value in l2tp_session_free
  l2tp: WARN_ON rather than BUG_ON in l2tp_session_free

 net/l2tp/l2tp_core.c    | 22 ++++++++++------------
 net/l2tp/l2tp_debugfs.c |  5 ++++-
 net/l2tp/l2tp_ip.c      | 12 ++++++++----
 net/l2tp/l2tp_ip6.c     |  6 ++++--
 net/l2tp/l2tp_ppp.c     | 16 ++++++++++++----
 5 files changed, 38 insertions(+), 23 deletions(-)

Comments

David Miller July 25, 2020, 12:19 a.m. UTC | #1 
From: Tom Parkin <tparkin@katalix.com>
Date: Fri, 24 Jul 2020 16:31:48 +0100

> l2tp hasn't been kept up to date with the static analysis checks offered
> by checkpatch.pl.
> 
> This patchset builds on the series: "l2tp: cleanup checkpatch.pl
> warnings" and "l2tp: further checkpatch.pl cleanups" to resolve some of
> the remaining checkpatch warnings in l2tp.

Series applied, thanks Tom.