| Message ID | 20200724041426.GB25409@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v8,net-next] net: hyperv: dump TX indirection table to ethtool regs | expand |
> -----Original Message----- > From: Chi Song <chisong@linux.microsoft.com> > Sent: Friday, July 24, 2020 12:14 AM > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>; > Wei Liu <wei.liu@kernel.org>; David S. Miller <davem@davemloft.net>; Jakub > Kicinski <kuba@kernel.org> > Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v8 net-next] net: hyperv: dump TX indirection table to ethtool > regs > > An imbalanced TX indirection table causes netvsc to have low > performance. This table is created and managed during runtime. To help > better diagnose performance issues caused by imbalanced tables, it needs > make TX indirection tables visible. > > Because TX indirection table is driver specified information, so > display it via ethtool register dump. > > Signed-off-by: Chi Song <chisong@microsoft.com> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
From: Chi Song <chisong@linux.microsoft.com> Date: Thu, 23 Jul 2020 21:14:26 -0700 > An imbalanced TX indirection table causes netvsc to have low > performance. This table is created and managed during runtime. To help > better diagnose performance issues caused by imbalanced tables, it needs > make TX indirection tables visible. > > Because TX indirection table is driver specified information, so > display it via ethtool register dump. > > Signed-off-by: Chi Song <chisong@microsoft.com> Applied, thank you.
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6267f706e8ee..3288221726ea 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -1934,6 +1934,23 @@ static int netvsc_set_features(struct net_device *ndev, return ret; } +static int netvsc_get_regs_len(struct net_device *netdev) +{ + return VRSS_SEND_TAB_SIZE * sizeof(u32); +} + +static void netvsc_get_regs(struct net_device *netdev, + struct ethtool_regs *regs, void *p) +{ + struct net_device_context *ndc = netdev_priv(netdev); + u32 *regs_buff = p; + + /* increase the version, if buffer format is changed. */ + regs->version = 1; + + memcpy(regs_buff, ndc->tx_table, VRSS_SEND_TAB_SIZE * sizeof(u32)); +} + static u32 netvsc_get_msglevel(struct net_device *ndev) { struct net_device_context *ndev_ctx = netdev_priv(ndev); @@ -1950,6 +1967,8 @@ static void netvsc_set_msglevel(struct net_device *ndev, u32 val) static const struct ethtool_ops ethtool_ops = { .get_drvinfo = netvsc_get_drvinfo, + .get_regs_len = netvsc_get_regs_len, + .get_regs = netvsc_get_regs, .get_msglevel = netvsc_get_msglevel, .set_msglevel = netvsc_set_msglevel, .get_link = ethtool_op_get_link,
An imbalanced TX indirection table causes netvsc to have low performance. This table is created and managed during runtime. To help better diagnose performance issues caused by imbalanced tables, it needs make TX indirection tables visible. Because TX indirection table is driver specified information, so display it via ethtool register dump. Signed-off-by: Chi Song <chisong@microsoft.com> --- v8: fix corrupt patch file v7: move to ethtool register dump v6: update names to be more precise, remove useless assignment v5: update variable orders v4: use a separated group to organize tx_indirection better, change location of attributes init/exit to netvsc_drv_init/exit drivers/net/hyperv/netvsc_drv.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)