mbox series

[net-next,0/6] l2tp: further checkpatch.pl cleanups

Message ID 20200723112955.19808-1-tparkin@katalix.com
Headers show
Series l2tp: further checkpatch.pl cleanups | expand

Message

Tom Parkin July 23, 2020, 11:29 a.m. UTC 
l2tp hasn't been kept up to date with the static analysis checks offered
by checkpatch.pl.

This patchset builds on the series "l2tp: cleanup checkpatch.pl
warnings".  It includes small refactoring changes which improve code
quality and resolve a subset of the checkpatch warnings for the l2tp
codebase.

Tom Parkin (6):
  l2tp: cleanup comparisons to NULL
  l2tp: cleanup unnecessary braces in if statements
  l2tp: check socket address type in l2tp_dfs_seq_tunnel_show
  l2tp: cleanup netlink send of tunnel address information
  l2tp: cleanup netlink tunnel create address handling
  l2tp: cleanup kzalloc calls

 net/l2tp/l2tp_core.c    |  30 +++---
 net/l2tp/l2tp_debugfs.c |  20 ++--
 net/l2tp/l2tp_ip.c      |   2 +-
 net/l2tp/l2tp_ip6.c     |   2 +-
 net/l2tp/l2tp_netlink.c | 206 ++++++++++++++++++++++------------------
 net/l2tp/l2tp_ppp.c     |  59 ++++++------
 6 files changed, 169 insertions(+), 150 deletions(-)

Comments

James Chapman July 23, 2020, 6 p.m. UTC | #1 
On 23/07/2020 12:29, Tom Parkin wrote:
> l2tp hasn't been kept up to date with the static analysis checks offered
> by checkpatch.pl.
>
> This patchset builds on the series "l2tp: cleanup checkpatch.pl
> warnings".  It includes small refactoring changes which improve code
> quality and resolve a subset of the checkpatch warnings for the l2tp
> codebase.
>
> Tom Parkin (6):
>   l2tp: cleanup comparisons to NULL
>   l2tp: cleanup unnecessary braces in if statements
>   l2tp: check socket address type in l2tp_dfs_seq_tunnel_show
>   l2tp: cleanup netlink send of tunnel address information
>   l2tp: cleanup netlink tunnel create address handling
>   l2tp: cleanup kzalloc calls
>
>  net/l2tp/l2tp_core.c    |  30 +++---
>  net/l2tp/l2tp_debugfs.c |  20 ++--
>  net/l2tp/l2tp_ip.c      |   2 +-
>  net/l2tp/l2tp_ip6.c     |   2 +-
>  net/l2tp/l2tp_netlink.c | 206 ++++++++++++++++++++++------------------
>  net/l2tp/l2tp_ppp.c     |  59 ++++++------
>  6 files changed, 169 insertions(+), 150 deletions(-)
>
Reviewed-by: James Chapman <jchapman@katalix.com>
David Miller July 23, 2020, 6:54 p.m. UTC | #2 
From: James Chapman <jchapman@katalix.com>
Date: Thu, 23 Jul 2020 19:00:02 +0100

> On 23/07/2020 12:29, Tom Parkin wrote:
>> l2tp hasn't been kept up to date with the static analysis checks offered
>> by checkpatch.pl.
>>
>> This patchset builds on the series "l2tp: cleanup checkpatch.pl
>> warnings".  It includes small refactoring changes which improve code
>> quality and resolve a subset of the checkpatch warnings for the l2tp
>> codebase.
 ...
> Reviewed-by: James Chapman <jchapman@katalix.com>

Series applied.