| Message ID | 20200708072401.169150-4-joyce.ooi@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: eth: altera: tse: Add PTP and mSGDMA prefetcher | expand |
On 7/8/20 2:23 AM, Ooi, Joyce wrote: > From: Dalon Westergreen <dalon.westergreen@intel.com> > > The declaration of struct altera_dmaops does not have > identifier names. Add identifier names to confrom with > required coding styles. > > Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com> > Signed-off-by: Joyce Ooi <joyce.ooi@intel.com> > --- > v2: no change > v3: no change > v4: no change > --- > drivers/net/ethernet/altera/altera_tse.h | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h > index f17acfb579a0..7d0c98fc103e 100644 > --- a/drivers/net/ethernet/altera/altera_tse.h > +++ b/drivers/net/ethernet/altera/altera_tse.h > @@ -385,20 +385,22 @@ struct altera_tse_private; > struct altera_dmaops { > int altera_dtype; > int dmamask; > - void (*reset_dma)(struct altera_tse_private *); > - void (*enable_txirq)(struct altera_tse_private *); > - void (*enable_rxirq)(struct altera_tse_private *); > - void (*disable_txirq)(struct altera_tse_private *); > - void (*disable_rxirq)(struct altera_tse_private *); > - void (*clear_txirq)(struct altera_tse_private *); > - void (*clear_rxirq)(struct altera_tse_private *); > - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); > - u32 (*tx_completions)(struct altera_tse_private *); > - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); > - u32 (*get_rx_status)(struct altera_tse_private *); > - int (*init_dma)(struct altera_tse_private *); > - void (*uninit_dma)(struct altera_tse_private *); > - void (*start_rxdma)(struct altera_tse_private *); > + void (*reset_dma)(struct altera_tse_private *priv); > + void (*enable_txirq)(struct altera_tse_private *priv); > + void (*enable_rxirq)(struct altera_tse_private *priv); > + void (*disable_txirq)(struct altera_tse_private *priv); > + void (*disable_rxirq)(struct altera_tse_private *priv); > + void (*clear_txirq)(struct altera_tse_private *priv); > + void (*clear_rxirq)(struct altera_tse_private *priv); > + int (*tx_buffer)(struct altera_tse_private *priv, > + struct tse_buffer *buffer); > + u32 (*tx_completions)(struct altera_tse_private *priv); > + void (*add_rx_desc)(struct altera_tse_private *priv, > + struct tse_buffer *buffer); > + u32 (*get_rx_status)(struct altera_tse_private *priv); > + int (*init_dma)(struct altera_tse_private *priv); > + void (*uninit_dma)(struct altera_tse_private *priv); > + void (*start_rxdma)(struct altera_tse_private *priv); > }; > > /* This structure is private to each device. > Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h index f17acfb579a0..7d0c98fc103e 100644 --- a/drivers/net/ethernet/altera/altera_tse.h +++ b/drivers/net/ethernet/altera/altera_tse.h @@ -385,20 +385,22 @@ struct altera_tse_private; struct altera_dmaops { int altera_dtype; int dmamask; - void (*reset_dma)(struct altera_tse_private *); - void (*enable_txirq)(struct altera_tse_private *); - void (*enable_rxirq)(struct altera_tse_private *); - void (*disable_txirq)(struct altera_tse_private *); - void (*disable_rxirq)(struct altera_tse_private *); - void (*clear_txirq)(struct altera_tse_private *); - void (*clear_rxirq)(struct altera_tse_private *); - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); - u32 (*tx_completions)(struct altera_tse_private *); - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); - u32 (*get_rx_status)(struct altera_tse_private *); - int (*init_dma)(struct altera_tse_private *); - void (*uninit_dma)(struct altera_tse_private *); - void (*start_rxdma)(struct altera_tse_private *); + void (*reset_dma)(struct altera_tse_private *priv); + void (*enable_txirq)(struct altera_tse_private *priv); + void (*enable_rxirq)(struct altera_tse_private *priv); + void (*disable_txirq)(struct altera_tse_private *priv); + void (*disable_rxirq)(struct altera_tse_private *priv); + void (*clear_txirq)(struct altera_tse_private *priv); + void (*clear_rxirq)(struct altera_tse_private *priv); + int (*tx_buffer)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*tx_completions)(struct altera_tse_private *priv); + void (*add_rx_desc)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*get_rx_status)(struct altera_tse_private *priv); + int (*init_dma)(struct altera_tse_private *priv); + void (*uninit_dma)(struct altera_tse_private *priv); + void (*start_rxdma)(struct altera_tse_private *priv); }; /* This structure is private to each device.