mbox series

[v2,net-next,00/10] l2tp: cleanup checkpatch.pl warnings

Message ID 20200722163214.7920-1-tparkin@katalix.com
Headers show
Series l2tp: cleanup checkpatch.pl warnings | expand

Message

Tom Parkin July 22, 2020, 4:32 p.m. UTC
l2tp hasn't been kept up to date with the static analysis checks offered
by checkpatch.pl.

This series addresses a range of minor issues which don't involve large
changes to code structure.  The changes include:

 * tweaks to use of whitespace, comment style, line breaks,
   and indentation

 * two minor modifications to code to use a function or macro suggested
   by checkpatch

v1 -> v2

 * combine related patches (patches fixing whitespace issues, patches
   addressing comment style)

 * respin the single large patchset into a multiple smaller series for
   easier review

Tom Parkin (10):
  l2tp: cleanup whitespace use
  l2tp: cleanup comments
  l2tp: cleanup difficult-to-read line breaks
  l2tp: cleanup wonky alignment of line-broken function calls
  l2tp: cleanup suspect code indent
  l2tp: add identifier name in function pointer prototype
  l2tp: prefer using BIT macro
  l2tp: prefer seq_puts for unformatted output
  l2tp: line-break long function prototypes
  l2tp: avoid precidence issues in L2TP_SKB_CB macro

 net/l2tp/l2tp_core.c    | 69 +++++++++++++++++-----------------
 net/l2tp/l2tp_core.h    | 82 +++++++++++++++++------------------------
 net/l2tp/l2tp_debugfs.c | 11 ++----
 net/l2tp/l2tp_eth.c     | 19 ++++------
 net/l2tp/l2tp_ip.c      | 17 +++++----
 net/l2tp/l2tp_ip6.c     | 29 +++++++--------
 net/l2tp/l2tp_netlink.c | 75 ++++++++++++++++---------------------
 net/l2tp/l2tp_ppp.c     | 20 +++++-----
 8 files changed, 145 insertions(+), 177 deletions(-)

Comments

James Chapman July 22, 2020, 6:31 p.m. UTC | #1
On 22/07/2020 17:32, Tom Parkin wrote:
> l2tp hasn't been kept up to date with the static analysis checks offered
> by checkpatch.pl.
>
> This series addresses a range of minor issues which don't involve large
> changes to code structure.  The changes include:
>
>  * tweaks to use of whitespace, comment style, line breaks,
>    and indentation
>
>  * two minor modifications to code to use a function or macro suggested
>    by checkpatch
>
> v1 -> v2
>
>  * combine related patches (patches fixing whitespace issues, patches
>    addressing comment style)
>
>  * respin the single large patchset into a multiple smaller series for
>    easier review
>
> Tom Parkin (10):
>   l2tp: cleanup whitespace use
>   l2tp: cleanup comments
>   l2tp: cleanup difficult-to-read line breaks
>   l2tp: cleanup wonky alignment of line-broken function calls
>   l2tp: cleanup suspect code indent
>   l2tp: add identifier name in function pointer prototype
>   l2tp: prefer using BIT macro
>   l2tp: prefer seq_puts for unformatted output
>   l2tp: line-break long function prototypes
>   l2tp: avoid precidence issues in L2TP_SKB_CB macro
>
>  net/l2tp/l2tp_core.c    | 69 +++++++++++++++++-----------------
>  net/l2tp/l2tp_core.h    | 82 +++++++++++++++++------------------------
>  net/l2tp/l2tp_debugfs.c | 11 ++----
>  net/l2tp/l2tp_eth.c     | 19 ++++------
>  net/l2tp/l2tp_ip.c      | 17 +++++----
>  net/l2tp/l2tp_ip6.c     | 29 +++++++--------
>  net/l2tp/l2tp_netlink.c | 75 ++++++++++++++++---------------------
>  net/l2tp/l2tp_ppp.c     | 20 +++++-----
>  8 files changed, 145 insertions(+), 177 deletions(-)
>
Reviewed-by: James Chapman <jchapman@katalix.com>
David Miller July 23, 2020, 1:08 a.m. UTC | #2
From: Tom Parkin <tparkin@katalix.com>
Date: Wed, 22 Jul 2020 17:32:04 +0100

> l2tp hasn't been kept up to date with the static analysis checks offered
> by checkpatch.pl.
> 
> This series addresses a range of minor issues which don't involve large
> changes to code structure.  The changes include:
> 
>  * tweaks to use of whitespace, comment style, line breaks,
>    and indentation
> 
>  * two minor modifications to code to use a function or macro suggested
>    by checkpatch
> 
> v1 -> v2
> 
>  * combine related patches (patches fixing whitespace issues, patches
>    addressing comment style)
> 
>  * respin the single large patchset into a multiple smaller series for
>    easier review

Series applied, thank you.