mbox series

[net-next,0/7] Add an MDIO sub-node under MACB

Message ID 20200721100234.1302910-1-codrin.ciubotariu@microchip.com
Headers show
Series Add an MDIO sub-node under MACB | expand

Message

Codrin Ciubotariu July 21, 2020, 10:02 a.m. UTC 
Adding the PHY nodes directly under the Ethernet node became deprecated,
so the aim of this patch series is to make MACB use an MDIO node as
container for MDIO devices.
This patch series starts with a small patch to use the device-managed
devm_mdiobus_alloc(). In the next two patches we update the bindings and
adapt macb driver to parse the device-tree PHY nodes from under an MDIO
node. The last patches add the MDIO node in the device-trees of sama5d2,
sama5d3, samad4 and sam9x60 boards.

Codrin Ciubotariu (7):
  net: macb: use device-managed devm_mdiobus_alloc()
  macb: bindings doc: use an MDIO node as a container for PHY nodes
  net: macb: parse PHY nodes found under an MDIO node
  ARM: dts: at91: sama5d2: add an mdio sub-node to macb
  ARM: dts: at91: sama5d3: add an mdio sub-node to macb
  ARM: dts: at91: sama5d4: add an mdio sub-node to macb
  ARM: dts: at91: sam9x60: add an mdio sub-node to macb

 .../devicetree/bindings/net/macb.txt          | 15 ++++++++++++---
 arch/arm/boot/dts/at91-sam9x60ek.dts          |  8 ++++++--
 arch/arm/boot/dts/at91-sama5d27_som1.dtsi     | 16 ++++++++++------
 arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi   | 17 ++++++++++-------
 arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts     | 13 ++++++++-----
 arch/arm/boot/dts/at91-sama5d2_xplained.dts   | 12 ++++++++----
 arch/arm/boot/dts/at91-sama5d3_xplained.dts   | 16 ++++++++++++----
 arch/arm/boot/dts/at91-sama5d4_xplained.dts   | 12 ++++++++----
 drivers/net/ethernet/cadence/macb_main.c      | 19 ++++++++++++-------
 9 files changed, 86 insertions(+), 42 deletions(-)

Comments

Andrew Lunn July 21, 2020, 1:36 p.m. UTC | #1 
> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>  			 * decrement it before returning.
>  			 */
>  			of_node_put(child);
> -
>  			return of_mdiobus_register(bp->mii_bus, np);
>  		}

Please avoid white space changes like this.

Otherwise this looks O.K.

       Andrew
Codrin Ciubotariu July 21, 2020, 1:40 p.m. UTC | #2 
On 21.07.2020 16:36, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>>                         * decrement it before returning.
>>                         */
>>                        of_node_put(child);
>> -
>>                        return of_mdiobus_register(bp->mii_bus, np);
>>                }
> 
> Please avoid white space changes like this.

Sorry about this, it was not intended. Will fix in v2. Thanks!

> 
> Otherwise this looks O.K.
> 
>         Andrew
>
Codrin Ciubotariu July 21, 2020, 1:42 p.m. UTC | #3 
On 21.07.2020 16:36, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>>                         * decrement it before returning.
>>                         */
>>                        of_node_put(child);
>> -
>>                        return of_mdiobus_register(bp->mii_bus, np);
>>                }
> 
> Please avoid white space changes like this.

Sorry about this, it was not intended. Will fix in v2. Thanks!

> 
> Otherwise this looks O.K.
> 
>         Andrew
>
Codrin Ciubotariu July 21, 2020, 1:44 p.m. UTC | #4 
On 21.07.2020 16:36, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>>                         * decrement it before returning.
>>                         */
>>                        of_node_put(child);
>> -
>>                        return of_mdiobus_register(bp->mii_bus, np);
>>                }
> 
> Please avoid white space changes like this.

Sorry about this, it was not intended. Will fix in v2. Thanks!

> 
> Otherwise this looks O.K.
> 
>         Andrew
>