diff mbox series

[v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

Message ID 866b4a34-cd4e-0120-904f-13669257a765@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX | expand

Commit Message

Bixuan Cui July 20, 2020, 1:58 a.m. UTC 
Fix the warning: [-Werror=-Wframe-larger-than=]

drivers/net/ethernet/neterion/vxge/vxge-main.c:
In function'VXGE_COMPLETE_VPATH_TX.isra.37':
drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
warning: the frame size of 1056 bytes is larger than 1024 bytes

Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't
have much impact on performance and functionality.

Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2: Dropping the NR_SKB_COMPLETED to 16.

 drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1


.

Comments

David Miller July 21, 2020, 1:38 a.m. UTC | #1 
From: Bixuan Cui <cuibixuan@huawei.com>
Date: Mon, 20 Jul 2020 09:58:39 +0800

> Fix the warning: [-Werror=-Wframe-larger-than=]
> 
> drivers/net/ethernet/neterion/vxge/vxge-main.c:
> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
> warning: the frame size of 1056 bytes is larger than 1024 bytes
> 
> Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't
> have much impact on performance and functionality.
> 
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2: Dropping the NR_SKB_COMPLETED to 16.

Applied.
Bixuan Cui July 21, 2020, 12:34 p.m. UTC | #2 
On 2020/7/21 9:38, David Miller wrote:
> From: Bixuan Cui <cuibixuan@huawei.com>
> Date: Mon, 20 Jul 2020 09:58:39 +0800
> 
>> Fix the warning: [-Werror=-Wframe-larger-than=]
>>
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:
>> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
>> warning: the frame size of 1056 bytes is larger than 1024 bytes
>>
>> Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't
>> have much impact on performance and functionality.
>>
>> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>> v2: Dropping the NR_SKB_COMPLETED to 16.
> Applied.
thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index b0faa737b817..f905d0fe7d54 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -98,7 +98,7 @@  static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo)
 {
 	struct sk_buff **skb_ptr = NULL;
 	struct sk_buff **temp;
-#define NR_SKB_COMPLETED 128
+#define NR_SKB_COMPLETED 16
 	struct sk_buff *completed[NR_SKB_COMPLETED];
 	int more;