| Message ID | 20200720155530.1173732-1-a.darwish@linutronix.de |
|---|---|
| Headers | show |
| Series | seqlock: Extend seqcount API with associated locks | expand |
On Mon, Jul 20, 2020 at 05:55:06PM +0200, Ahmed S. Darwish wrote: > Hi, > > This is v4 of the seqlock patch series: > > [PATCH v1 00/25] > https://lore.kernel.org/lkml/20200519214547.352050-1-a.darwish@linutronix.de > > [PATCH v2 00/06] (bugfixes-only, merged) > https://lore.kernel.org/lkml/20200603144949.1122421-1-a.darwish@linutronix.de > > [PATCH v2 00/18] > https://lore.kernel.org/lkml/20200608005729.1874024-1-a.darwish@linutronix.de > > [PATCH v3 00/20] > https://lore.kernel.org/lkml/20200630054452.3675847-1-a.darwish@linutronix.de > > It is based over: > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git :: locking/core > Please include an explanation of the patch series in the cover letter. It looks like you sent it in v1 and then stopped including it. That doesn't work; reviewers shouldn't have to read all previous versions too and try to guess which parts are still up-to-date. - Eric
On Mon, Jul 20, 2020 at 09:49:12AM -0700, Eric Biggers wrote: > On Mon, Jul 20, 2020 at 05:55:06PM +0200, Ahmed S. Darwish wrote: > > Hi, > > > > This is v4 of the seqlock patch series: > > > > [PATCH v1 00/25] > > https://lore.kernel.org/lkml/20200519214547.352050-1-a.darwish@linutronix.de > > > > [PATCH v2 00/06] (bugfixes-only, merged) > > https://lore.kernel.org/lkml/20200603144949.1122421-1-a.darwish@linutronix.de > > > > [PATCH v2 00/18] > > https://lore.kernel.org/lkml/20200608005729.1874024-1-a.darwish@linutronix.de > > > > [PATCH v3 00/20] > > https://lore.kernel.org/lkml/20200630054452.3675847-1-a.darwish@linutronix.de > > > > It is based over: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git :: locking/core > > > > Please include an explanation of the patch series in the cover letter. It looks > like you sent it in v1 and then stopped including it. That doesn't work; > reviewers shouldn't have to read all previous versions too and try to guess > which parts are still up-to-date. > Noted. Thanks for the heads-up. -- Ahmed S. Darwish Linutronix GmbH
Hi, This is v4 of the seqlock patch series: [PATCH v1 00/25] https://lore.kernel.org/lkml/20200519214547.352050-1-a.darwish@linutronix.de [PATCH v2 00/06] (bugfixes-only, merged) https://lore.kernel.org/lkml/20200603144949.1122421-1-a.darwish@linutronix.de [PATCH v2 00/18] https://lore.kernel.org/lkml/20200608005729.1874024-1-a.darwish@linutronix.de [PATCH v3 00/20] https://lore.kernel.org/lkml/20200630054452.3675847-1-a.darwish@linutronix.de It is based over: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git :: locking/core Changelog ========= - Unconditionally use C11 _Generic() expressions for seqcount_locktype_t switching. Thanks to Peter, pushing for 6ec4476ac825 ("Raise gcc version requirement to 4.9"). - Compress the new seqcount_locktype_t code code by using generative macros, as suggested by Peter here: https://lkml.kernel.org/r/20200708122938.GQ4800@hirez.programming.kicks-ass.net Keep *all* functions that are to be invoked by call-sites out of such generative macros though. This simplifies the generative macros code, and (more importantly) make the newly exported seqlock.h API explicit. - Make all documentation "RST-lite", for better readability from text editors. - Add additional clean-ups at the start of the series for better overall readability of seqlock.h code, and for future extensibility. Thanks, 8<-------------- Ahmed S. Darwish (24): Documentation: locking: Describe seqlock design and usage seqlock: Properly format kernel-doc code samples seqlock: seqcount_t latch: End read sections with read_seqcount_retry() seqlock: Reorder seqcount_t and seqlock_t API definitions seqlock: Add kernel-doc for seqcount_t and seqlock_t APIs seqlock: Implement raw_seqcount_begin() in terms of raw_read_seqcount() lockdep: Add preemption enabled/disabled assertion APIs seqlock: lockdep assert non-preemptibility on seqcount_t write seqlock: Extend seqcount API with associated locks seqlock: Align multi-line macros newline escapes at 72 columns dma-buf: Remove custom seqcount lockdep class key dma-buf: Use sequence counter with associated wound/wait mutex sched: tasks: Use sequence counter with associated spinlock netfilter: conntrack: Use sequence counter with associated spinlock netfilter: nft_set_rbtree: Use sequence counter with associated rwlock xfrm: policy: Use sequence counters with associated lock timekeeping: Use sequence counter with associated raw spinlock vfs: Use sequence counter with associated spinlock raid5: Use sequence counter with associated spinlock iocost: Use sequence counter with associated spinlock NFSv4: Use sequence counter with associated spinlock userfaultfd: Use sequence counter with associated spinlock kvm/eventfd: Use sequence counter with associated spinlock hrtimer: Use sequence counter with associated raw spinlock Documentation/locking/index.rst | 1 + Documentation/locking/seqlock.rst | 222 ++++ block/blk-iocost.c | 5 +- drivers/dma-buf/dma-resv.c | 15 +- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 - drivers/md/raid5.c | 2 +- drivers/md/raid5.h | 2 +- fs/dcache.c | 2 +- fs/fs_struct.c | 4 +- fs/nfs/nfs4_fs.h | 2 +- fs/nfs/nfs4state.c | 2 +- fs/userfaultfd.c | 4 +- include/linux/dcache.h | 2 +- include/linux/dma-resv.h | 4 +- include/linux/fs_struct.h | 2 +- include/linux/hrtimer.h | 2 +- include/linux/kvm_irqfd.h | 2 +- include/linux/lockdep.h | 19 + include/linux/sched.h | 2 +- include/linux/seqlock.h | 1139 +++++++++++++---- include/net/netfilter/nf_conntrack.h | 2 +- init/init_task.c | 3 +- kernel/fork.c | 2 +- kernel/time/hrtimer.c | 13 +- kernel/time/timekeeping.c | 19 +- lib/Kconfig.debug | 1 + net/netfilter/nf_conntrack_core.c | 5 +- net/netfilter/nft_set_rbtree.c | 4 +- net/xfrm/xfrm_policy.c | 10 +- virt/kvm/eventfd.c | 2 +- 30 files changed, 1173 insertions(+), 323 deletions(-) create mode 100644 Documentation/locking/seqlock.rst base-commit: a9232dc5607dbada801f2fe83ea307cda762969a -- 2.20.1