mbox series

[ethtool,0/4] Add support for IGC driver

Message ID 20200707234800.39119-1-andre.guedes@intel.com
Headers show
Series Add support for IGC driver | expand

Message

Andre Guedes July 7, 2020, 11:47 p.m. UTC 
Hi all,

This patch series adds support for parsing registers dumped by the IGC driver.
For now, the following registers are parsed:

	* Receive Address Low (RAL)
	* Receive Address High (RAH)
	* Receive Control (RCTL)
	* VLAN Priority Queue Filter (VLANPQF)
	* EType Queue Filter (ETQF)

More registers should be parsed as we need/enable them.

Cheers,
Andre

Andre Guedes (4):
  Add IGC driver support
  igc: Parse RCTL register fields
  igc: Parse VLANPQF register fields
  igc: Parse ETQF registers

 Makefile.am |   3 +-
 ethtool.c   |   1 +
 igc.c       | 283 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 internal.h  |   3 +
 4 files changed, 289 insertions(+), 1 deletion(-)
 create mode 100644 igc.c

Comments

Michal Kubecek July 20, 2020, 12:10 a.m. UTC | #1 
On Tue, Jul 07, 2020 at 04:47:56PM -0700, Andre Guedes wrote:
> Hi all,
> 
> This patch series adds support for parsing registers dumped by the IGC driver.
> For now, the following registers are parsed:
> 
> 	* Receive Address Low (RAL)
> 	* Receive Address High (RAH)
> 	* Receive Control (RCTL)
> 	* VLAN Priority Queue Filter (VLANPQF)
> 	* EType Queue Filter (ETQF)
> 
> More registers should be parsed as we need/enable them.
> 
> Cheers,
> Andre

Series merged. But please consider making the output consistent with
other Intel drivers which use lowercase keywords for values (e.g.
"enabled") and "yes"/"no" for bool values (rather than "True" / "False").

Michal

> 
> Andre Guedes (4):
>   Add IGC driver support
>   igc: Parse RCTL register fields
>   igc: Parse VLANPQF register fields
>   igc: Parse ETQF registers
> 
>  Makefile.am |   3 +-
>  ethtool.c   |   1 +
>  igc.c       | 283 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  internal.h  |   3 +
>  4 files changed, 289 insertions(+), 1 deletion(-)
>  create mode 100644 igc.c
> 
> -- 
> 2.26.2
>
Andre Guedes July 20, 2020, 6:27 p.m. UTC | #2 
Hi Michal,

Quoting Michal Kubecek (2020-07-19 17:10:46)
> On Tue, Jul 07, 2020 at 04:47:56PM -0700, Andre Guedes wrote:
> > Hi all,
> > 
> > This patch series adds support for parsing registers dumped by the IGC driver.
> > For now, the following registers are parsed:
> > 
> >       * Receive Address Low (RAL)
> >       * Receive Address High (RAH)
> >       * Receive Control (RCTL)
> >       * VLAN Priority Queue Filter (VLANPQF)
> >       * EType Queue Filter (ETQF)
> > 
> > More registers should be parsed as we need/enable them.
> > 
> > Cheers,
> > Andre
> 
> Series merged. But please consider making the output consistent with
> other Intel drivers which use lowercase keywords for values (e.g.
> "enabled") and "yes"/"no" for bool values (rather than "True" / "False").

Sure, I'll send a patch aligning this.

- Andre