diff mbox series

[v2] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

Message ID 20200716155114.72625-1-paolo.pisati@canonical.com
State Accepted
Delegated to: David Miller
Headers show
Series [v2] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support | expand

Commit Message

Paolo Pisati July 16, 2020, 3:51 p.m. UTC
Fix ip_defrag.sh when CONFIG_NF_DEFRAG_IPV6=m:

$ sudo ./ip_defrag.sh
+ set -e
+ mktemp -u XXXXXX
+ readonly NETNS=ns-rGlXcw
+ trap cleanup EXIT
+ setup
+ ip netns add ns-rGlXcw
+ ip -netns ns-rGlXcw link set lo up
+ ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_high_thresh=9000000
+ ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_low_thresh=7000000
+ ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_time=1
+ ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_high_thresh=9000000
+ ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_low_thresh=7000000
+ ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_time=1
+ ip netns exec ns-rGlXcw sysctl -w net.netfilter.nf_conntrack_frag6_high_thresh=9000000
+ cleanup
+ ip netns del ns-rGlXcw

$ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
ls: cannot access '/proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh': No such file or directory

$ sudo modprobe nf_defrag_ipv6
$ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
-rw-r--r-- 1 root root 0 Jul 14 12:34 /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 tools/testing/selftests/net/ip_defrag.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jakub Kicinski July 17, 2020, 1:09 a.m. UTC | #1
On Thu, 16 Jul 2020 17:51:14 +0200 Paolo Pisati wrote:
> Fix ip_defrag.sh when CONFIG_NF_DEFRAG_IPV6=m:
> 
> $ sudo ./ip_defrag.sh
> + set -e
> + mktemp -u XXXXXX
> + readonly NETNS=ns-rGlXcw
> + trap cleanup EXIT
> + setup
> + ip netns add ns-rGlXcw
> + ip -netns ns-rGlXcw link set lo up
> + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_high_thresh=9000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_low_thresh=7000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_time=1
> + ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_high_thresh=9000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_low_thresh=7000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_time=1
> + ip netns exec ns-rGlXcw sysctl -w net.netfilter.nf_conntrack_frag6_high_thresh=9000000
> + cleanup
> + ip netns del ns-rGlXcw
> 
> $ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
> ls: cannot access '/proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh': No such file or directory
> 
> $ sudo modprobe nf_defrag_ipv6
> $ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
> -rw-r--r-- 1 root root 0 Jul 14 12:34 /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
David Miller July 17, 2020, 7:49 p.m. UTC | #2
From: Paolo Pisati <paolo.pisati@canonical.com>
Date: Thu, 16 Jul 2020 17:51:14 +0200

> Fix ip_defrag.sh when CONFIG_NF_DEFRAG_IPV6=m:
> 
> $ sudo ./ip_defrag.sh
> + set -e
> + mktemp -u XXXXXX
> + readonly NETNS=ns-rGlXcw
> + trap cleanup EXIT
> + setup
> + ip netns add ns-rGlXcw
> + ip -netns ns-rGlXcw link set lo up
> + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_high_thresh=9000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_low_thresh=7000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv4.ipfrag_time=1
> + ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_high_thresh=9000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_low_thresh=7000000
> + ip netns exec ns-rGlXcw sysctl -w net.ipv6.ip6frag_time=1
> + ip netns exec ns-rGlXcw sysctl -w net.netfilter.nf_conntrack_frag6_high_thresh=9000000
> + cleanup
> + ip netns del ns-rGlXcw
> 
> $ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
> ls: cannot access '/proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh': No such file or directory
> 
> $ sudo modprobe nf_defrag_ipv6
> $ ls -la /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
> -rw-r--r-- 1 root root 0 Jul 14 12:34 /proc/sys/net/netfilter/nf_conntrack_frag6_high_thresh
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/ip_defrag.sh b/tools/testing/selftests/net/ip_defrag.sh
index 15d3489ecd9c..ceb7ad4dbd94 100755
--- a/tools/testing/selftests/net/ip_defrag.sh
+++ b/tools/testing/selftests/net/ip_defrag.sh
@@ -6,6 +6,8 @@ 
 set +x
 set -e
 
+modprobe -q nf_defrag_ipv6
+
 readonly NETNS="ns-$(mktemp -u XXXXXX)"
 
 setup() {