Message ID | 20200716172611.5349-1-bruno.thomsen@gmail.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [v2,1/2] dt-bindings: fsl: add kamstrup flex concentrator to schema | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/dt-meta-schema | success |
Hi Bruno, On Thu, Jul 16, 2020 at 2:26 PM Bruno Thomsen <bruno.thomsen@gmail.com> wrote: > Limitations: Ethernet PHY type auto detection does not > work when using reset-{assert-us,deassert-us,gpios} > properties so it's using a fixed PHY type ID for now. Auto > detection worked when using the deprecated FEC properties > phy-reset-{gpios,duration,post-delay}. I think we need to understand this better. Why does it fail? I gave a test on an imx6q-sabresd and the Ethernet PHY (AR8031) could be properly detected using reset-{assert-us,deassert-us,gpios} properties inside the mdio node. Is this a Micrel KSZ8081 specific issue? Please report this issue to the Ethernet PHY folks.
Hi Fabio, Den tor. 16. jul. 2020 kl. 20.01 skrev Fabio Estevam <festevam@gmail.com>: > On Thu, Jul 16, 2020 at 2:26 PM Bruno Thomsen <bruno.thomsen@gmail.com> wrote: > > > Limitations: Ethernet PHY type auto detection does not > > work when using reset-{assert-us,deassert-us,gpios} > > properties so it's using a fixed PHY type ID for now. Auto > > detection worked when using the deprecated FEC properties > > phy-reset-{gpios,duration,post-delay}. > > I think we need to understand this better. Why does it fail? Yes, we need to locate the root cause. > I gave a test on an imx6q-sabresd and the Ethernet PHY (AR8031) could > be properly detected using reset-{assert-us,deassert-us,gpios} > properties inside the mdio node. Okay, thanks. > Is this a Micrel KSZ8081 specific issue? Maybe, I'm actually beginning to suspect that the issue might be related to polling vs interrupt mode. As all partially related examples I have seen uses interrupt mode and I have only configured poll mode. But the hardware does have the interrupt signal connected to the imx7. > Please report this issue to the Ethernet PHY folks. I'm going to send an Ethernet PHY mail tomorrow with the details I know at the moment. Just wanted to get an updated version of the device tree out in case of any other issues not related to the PHY part. /Bruno
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 05906e291e38..66627b272e40 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -299,6 +299,8 @@ properties: - enum: - fsl,imx7d-sdb # i.MX7 SabreSD Board - fsl,imx7d-sdb-reva # i.MX7 SabreSD Rev-A Board + - kam,imx7d-flex-concentrator # Kamstrup OMNIA Flex Concentrator + - kam,imx7d-flex-concentrator-mfg # Kamstrup OMNIA Flex Concentrator in manufacturing mode - novtech,imx7d-meerkat96 # i.MX7 Meerkat96 Board - technexion,imx7d-pico-dwarf # TechNexion i.MX7D Pico-Dwarf - technexion,imx7d-pico-hobbit # TechNexion i.MX7D Pico-Hobbit