mbox series

[net-next,v2,0/4] net: fec: a few improvements

Message ID 20200715154300.13933-1-sorganov@gmail.com
Headers show
Series net: fec: a few improvements | expand

Message

Sergey Organov July 15, 2020, 3:42 p.m. UTC 
This is a collection of simple improvements that reduce and/or
simplify code. They got developed out of attempt to use DP83640 PTP
PHY connected to built-in FEC (that has its own PTP support) of the
iMX 6SX micro-controller. The primary bug-fix was now submitted
separately, and this is the rest of the changes.

NOTE: the patches are developed and tested on 4.9.146, and rebased on
top of recent 'net-next/master', where, besides visual inspection, I
only tested that they do compile.

Sergey Organov (4):
  net: fec: enable to use PPS feature without time stamping
  net: fec: initialize clock with 0 rather than current kernel time
  net: fec: get rid of redundant code in fec_ptp_set()
  net: fec: replace snprintf() with strlcpy() in fec_ptp_init()

v2:
  - bug-fix patch from original series submitted separately
  - added Acked-by: where applicable
  
 drivers/net/ethernet/freescale/fec_ptp.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

Comments

Andy Duan July 16, 2020, 3 a.m. UTC | #1 
From: Sergey Organov <sorganov@gmail.com> Sent: Wednesday, July 15, 2020 11:43 PM
> This is a collection of simple improvements that reduce and/or simplify code.
> They got developed out of attempt to use DP83640 PTP PHY connected to
> built-in FEC (that has its own PTP support) of the iMX 6SX micro-controller.
> The primary bug-fix was now submitted separately, and this is the rest of the
> changes.
> 
> NOTE: the patches are developed and tested on 4.9.146, and rebased on top
> of recent 'net-next/master', where, besides visual inspection, I only tested
> that they do compile.
> 
> Sergey Organov (4):
>   net: fec: enable to use PPS feature without time stamping
>   net: fec: initialize clock with 0 rather than current kernel time
>   net: fec: get rid of redundant code in fec_ptp_set()
>   net: fec: replace snprintf() with strlcpy() in fec_ptp_init()
> 
> v2:
>   - bug-fix patch from original series submitted separately
>   - added Acked-by: where applicable
> 
>  drivers/net/ethernet/freescale/fec_ptp.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 

For the version: Acked-by: Fugang Duan <fugang.duan@nxp.com>
Thanks!
Jakub Kicinski July 16, 2020, 6:37 p.m. UTC | #2 
On Thu, 16 Jul 2020 03:00:56 +0000 Andy Duan wrote:
> From: Sergey Organov <sorganov@gmail.com> Sent: Wednesday, July 15, 2020 11:43 PM
> > This is a collection of simple improvements that reduce and/or simplify code.
> > They got developed out of attempt to use DP83640 PTP PHY connected to
> > built-in FEC (that has its own PTP support) of the iMX 6SX micro-controller.
> > The primary bug-fix was now submitted separately, and this is the rest of the
> > changes.
> > 
> > NOTE: the patches are developed and tested on 4.9.146, and rebased on top
> > of recent 'net-next/master', where, besides visual inspection, I only tested
> > that they do compile.
> > 
> > Sergey Organov (4):
> >   net: fec: enable to use PPS feature without time stamping
> >   net: fec: initialize clock with 0 rather than current kernel time
> >   net: fec: get rid of redundant code in fec_ptp_set()
> >   net: fec: replace snprintf() with strlcpy() in fec_ptp_init()

Applied, thanks!

> For the version: Acked-by: Fugang Duan <fugang.duan@nxp.com>

Thanks! In the future please make sure to have the tag as a separate
line, patchwork is not clever enough to pick it up if it doesn't start
at the start of the line :(