diff mbox series

[net] qed: Disable "MFW indication via attention" SPAM every 5 minutes

Message ID 1594764485-682-1-git-send-email-loberman@redhat.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] qed: Disable "MFW indication via attention" SPAM every 5 minutes | expand

Commit Message

Laurence Oberman July 14, 2020, 10:08 p.m. UTC
This is likely firmware causing this but its starting to annoy customers.
Change the message level to verbose to prevent the spam.
Note that this seems to only show up with ISCSI enabled on the HBA via the 
qedi driver.

Signed-off-by: Laurence Oberman <loberman@redhat.com>
---
 drivers/net/ethernet/qlogic/qed/qed_int.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Miller July 14, 2020, 10:16 p.m. UTC | #1
From: Laurence Oberman <loberman@redhat.com>
Date: Tue, 14 Jul 2020 18:08:05 -0400

> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the 
> qedi driver.
> 
> Signed-off-by: Laurence Oberman <loberman@redhat.com>

Applied, thanks.
Igor Russkikh July 15, 2020, 8:04 a.m. UTC | #2
> ----------------------------------------------------------------------
> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the
> 
> qedi driver.
> 
> Signed-off-by: Laurence Oberman <loberman@redhat.com>

Thanks for handling this, Laurence, we actually had the same fix in out of
tree driver recently, just missed upstreaming it.

Acked-by: Igor Russkikh <irusskikh@marvell.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index b7b974f..d853eb9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -1193,7 +1193,8 @@  static int qed_int_attentions(struct qed_hwfn *p_hwfn)
 			index, attn_bits, attn_acks, asserted_bits,
 			deasserted_bits, p_sb_attn_sw->known_attn);
 	} else if (asserted_bits == 0x100) {
-		DP_INFO(p_hwfn, "MFW indication via attention\n");
+		DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
+			   "MFW indication via attention\n");
 	} else {
 		DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
 			   "MFW indication [deassertion]\n");