Message ID | 20200714074814.108767-1-chenweilong@huawei.com |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | [v3,net] rtnetlink: Fix memory(net_device) leak when ->newlink fails | expand |
From: Weilong Chen <chenweilong@huawei.com> Date: Tue, 14 Jul 2020 15:48:14 +0800 > Fixes: e51fb152318ee6 (rtnetlink: fix a memory leak when ->newlink fails) This is still not correct. Read the feedback given to you carefully.
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 9aedc15736ad..85a4b0101f76 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -3343,7 +3343,8 @@ static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh, */ if (err < 0) { /* If device is not registered at all, free it now */ - if (dev->reg_state == NETREG_UNINITIALIZED) + if (dev->reg_state == NETREG_UNINITIALIZED || + dev->reg_state == NETREG_UNREGISTERED) free_netdev(dev); goto out; }