| Message ID | 20200710190407.31269-1-grandmaster@al2klimov.de |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [v2] MAINTAINERS: XDP: restrict N: and K: | expand |
On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > Rationale: > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > which has nothing to do with XDP. > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > --- > Better? > > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1d4aa7f942de..735e2475e926 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -18708,8 +18708,8 @@ F: include/trace/events/xdp.h > F: kernel/bpf/cpumap.c > F: kernel/bpf/devmap.c > F: net/core/xdp.c > -N: xdp > -K: xdp > +N: (?:\b|_)xdp > +K: (?:\b|_)xdp Generally, it's better to have comprehensive files lists rather than adding name matching regexes. Perhaps: --- MAINTAINERS | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 16854e47e8cb..2e96cbf15b31 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18763,13 +18763,19 @@ M: John Fastabend <john.fastabend@gmail.com> L: netdev@vger.kernel.org L: bpf@vger.kernel.org S: Supported -F: include/net/xdp.h +F: Documentation/networking/af_xdp.rst +F: include/net/xdp* F: include/trace/events/xdp.h +F: include/uapi/linux/if_xdp.h +F: include/uapi/linux/xdp_diag.h F: kernel/bpf/cpumap.c F: kernel/bpf/devmap.c F: net/core/xdp.c -N: xdp -K: xdp +F: net/xdp/ +F: samples/bpf/xdp* +F: tools/testing/selftests/bfp/*xdp* +F: tools/testing/selftests/bfp/*/*xdp* +K: (?:\b|_)xdp(?:\b|_) XDP SOCKETS (AF_XDP) M: Björn Töpel <bjorn.topel@intel.com>
On Fri, 10 Jul 2020 12:37:47 -0700 Joe Perches <joe@perches.com> wrote: > On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > > Rationale: > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > > which has nothing to do with XDP. > > > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > --- > > Better? > > > > MAINTAINERS | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 1d4aa7f942de..735e2475e926 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -18708,8 +18708,8 @@ F: include/trace/events/xdp.h > > F: kernel/bpf/cpumap.c > > F: kernel/bpf/devmap.c > > F: net/core/xdp.c > > -N: xdp > > -K: xdp > > +N: (?:\b|_)xdp > > +K: (?:\b|_)xdp > > Generally, it's better to have comprehensive files lists > rather than adding name matching regexes. I like below more direct matching of the files we already know are XDP related. The pattern match are meant to catch drivers containing XDP related bits. (small typo in your patch below) > Perhaps: > --- > MAINTAINERS | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 16854e47e8cb..2e96cbf15b31 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -18763,13 +18763,19 @@ M: John Fastabend <john.fastabend@gmail.com> > L: netdev@vger.kernel.org > L: bpf@vger.kernel.org > S: Supported > -F: include/net/xdp.h > +F: Documentation/networking/af_xdp.rst > +F: include/net/xdp* > F: include/trace/events/xdp.h > +F: include/uapi/linux/if_xdp.h > +F: include/uapi/linux/xdp_diag.h > F: kernel/bpf/cpumap.c > F: kernel/bpf/devmap.c > F: net/core/xdp.c > -N: xdp > -K: xdp > +F: net/xdp/ > +F: samples/bpf/xdp* > +F: tools/testing/selftests/bfp/*xdp* ^^^^ Typo, should be "bpf" > +F: tools/testing/selftests/bfp/*/*xdp* > +K: (?:\b|_)xdp(?:\b|_) > > XDP SOCKETS (AF_XDP) > M: Björn Töpel <bjorn.topel@intel.com> >
On Sat, 2020-07-11 at 10:23 +0200, Jesper Dangaard Brouer wrote: > On Fri, 10 Jul 2020 12:37:47 -0700 > Joe Perches <joe@perches.com> wrote: > > > On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > > > Rationale: > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > > > which has nothing to do with XDP. > > > > > > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> > > > --- > > > Better? > > > > > > MAINTAINERS | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 1d4aa7f942de..735e2475e926 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -18708,8 +18708,8 @@ F: include/trace/events/xdp.h > > > F: kernel/bpf/cpumap.c > > > F: kernel/bpf/devmap.c > > > F: net/core/xdp.c > > > -N: xdp > > > -K: xdp > > > +N: (?:\b|_)xdp > > > +K: (?:\b|_)xdp > > > > Generally, it's better to have comprehensive files lists > > rather than adding name matching regexes. > > I like below more direct matching of the files we already know are XDP > related. The pattern match are meant to catch drivers containing XDP > related bits. That's what the K: entry is for no? Anyway, if you agree with using the appropriate F: patterns, please submit it. I'm not going to. > (small typo in your patch below) > > > Perhaps: > > --- > > MAINTAINERS | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 16854e47e8cb..2e96cbf15b31 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -18763,13 +18763,19 @@ M: John Fastabend <john.fastabend@gmail.com> > > L: netdev@vger.kernel.org > > L: bpf@vger.kernel.org > > S: Supported > > -F: include/net/xdp.h > > +F: Documentation/networking/af_xdp.rst > > +F: include/net/xdp* > > F: include/trace/events/xdp.h > > +F: include/uapi/linux/if_xdp.h > > +F: include/uapi/linux/xdp_diag.h > > F: kernel/bpf/cpumap.c > > F: kernel/bpf/devmap.c > > F: net/core/xdp.c > > -N: xdp > > -K: xdp > > +F: net/xdp/ > > +F: samples/bpf/xdp* > > +F: tools/testing/selftests/bfp/*xdp* > ^^^^ > Typo, should be "bpf" > > > +F: tools/testing/selftests/bfp/*/*xdp* > > +K: (?:\b|_)xdp(?:\b|_) > > > > XDP SOCKETS (AF_XDP) > > M: Björn Töpel <bjorn.topel@intel.com> > > > >
diff --git a/MAINTAINERS b/MAINTAINERS index 1d4aa7f942de..735e2475e926 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18708,8 +18708,8 @@ F: include/trace/events/xdp.h F: kernel/bpf/cpumap.c F: kernel/bpf/devmap.c F: net/core/xdp.c -N: xdp -K: xdp +N: (?:\b|_)xdp +K: (?:\b|_)xdp XDP SOCKETS (AF_XDP) M: Björn Töpel <bjorn.topel@intel.com>
Rationale: Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" which has nothing to do with XDP. Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de> --- Better? MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)