diff mbox series

MAINTAINERS: XDP: restrict N: and K:

Message ID 20200709194257.26904-1-grandmaster@al2klimov.de
State Superseded
Delegated to: David Miller
Headers show
Series MAINTAINERS: XDP: restrict N: and K: | expand

Commit Message

Alexander A. Klimov July 9, 2020, 7:42 p.m. UTC 
Rationale:
Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
which has nothing to do with XDP.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
---
 See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel Borkmann July 9, 2020, 8:37 p.m. UTC | #1 
On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
> Rationale:
> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> which has nothing to do with XDP.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> ---
>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
> 
>   MAINTAINERS | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d4aa7f942de..2bb7feb838af 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
>   F:	kernel/bpf/cpumap.c
>   F:	kernel/bpf/devmap.c
>   F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +N:	(?:\b|_)xdp(?:\b|_)
> +K:	(?:\b|_)xdp(?:\b|_)

Please also include \W to generally match on non-alphanumeric char given you
explicitly want to avoid [a-z0-9] around the term xdp.

>   XDP SOCKETS (AF_XDP)
>   M:	Björn Töpel <bjorn.topel@intel.com>
>
Alexander A. Klimov July 10, 2020, 6:17 a.m. UTC | #2 
Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> Rationale:
>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> which has nothing to do with XDP.
>>
>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>> ---
>>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
>>
>>   MAINTAINERS | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 1d4aa7f942de..2bb7feb838af 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>   F:    kernel/bpf/cpumap.c
>>   F:    kernel/bpf/devmap.c
>>   F:    net/core/xdp.c
>> -N:    xdp
>> -K:    xdp
>> +N:    (?:\b|_)xdp(?:\b|_)
>> +K:    (?:\b|_)xdp(?:\b|_)
> 
> Please also include \W to generally match on non-alphanumeric char given 
> you
> explicitly want to avoid [a-z0-9] around the term xdp.
Aren't \W, ^ and $ already covered by \b?

> 
>>   XDP SOCKETS (AF_XDP)
>>   M:    Björn Töpel <bjorn.topel@intel.com>
>>
>
Daniel Borkmann July 10, 2020, 3:14 p.m. UTC | #3 
On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>>> Rationale:
>>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>>> which has nothing to do with XDP.
>>>
>>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>>> ---
>>>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
>>>
>>>   MAINTAINERS | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 1d4aa7f942de..2bb7feb838af 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>>   F:    kernel/bpf/cpumap.c
>>>   F:    kernel/bpf/devmap.c
>>>   F:    net/core/xdp.c
>>> -N:    xdp
>>> -K:    xdp
>>> +N:    (?:\b|_)xdp(?:\b|_)
>>> +K:    (?:\b|_)xdp(?:\b|_)
>>
>> Please also include \W to generally match on non-alphanumeric char given you
>> explicitly want to avoid [a-z0-9] around the term xdp.
> Aren't \W, ^ and $ already covered by \b?

Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
In case this goes via net or net-next tree:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Joe Perches July 10, 2020, 4 p.m. UTC | #4 
On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
> On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
> > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
> > > > Rationale:
> > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > > > which has nothing to do with XDP.
[]
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
> > > >   F:    kernel/bpf/cpumap.c
> > > >   F:    kernel/bpf/devmap.c
> > > >   F:    net/core/xdp.c
> > > > -N:    xdp
> > > > -K:    xdp
> > > > +N:    (?:\b|_)xdp(?:\b|_)
> > > > +K:    (?:\b|_)xdp(?:\b|_)
> > > 
> > > Please also include \W to generally match on non-alphanumeric char given you
> > > explicitly want to avoid [a-z0-9] around the term xdp.
> > Aren't \W, ^ and $ already covered by \b?
> 
> Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
> In case this goes via net or net-next tree:

This N: pattern does not match files like:

	samples/bpf/xdp1_kern.c

and does match files like:

	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c

Should it?
Toke Høiland-Jørgensen July 10, 2020, 4:12 p.m. UTC | #5 
Joe Perches <joe@perches.com> writes:

> On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>> On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>> > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> > > > Rationale:
>> > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> > > > which has nothing to do with XDP.
> []
>> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>> > > >   F:    kernel/bpf/cpumap.c
>> > > >   F:    kernel/bpf/devmap.c
>> > > >   F:    net/core/xdp.c
>> > > > -N:    xdp
>> > > > -K:    xdp
>> > > > +N:    (?:\b|_)xdp(?:\b|_)
>> > > > +K:    (?:\b|_)xdp(?:\b|_)
>> > > 
>> > > Please also include \W to generally match on non-alphanumeric char given you
>> > > explicitly want to avoid [a-z0-9] around the term xdp.
>> > Aren't \W, ^ and $ already covered by \b?
>> 
>> Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>> In case this goes via net or net-next tree:
>
> This N: pattern does not match files like:
>
> 	samples/bpf/xdp1_kern.c
>
> and does match files like:
>
> 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>
> Should it?

I think the idea is that it should match both?

-Toke
Alexander A. Klimov July 10, 2020, 6:18 p.m. UTC | #6 
Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
> Joe Perches <joe@perches.com> writes:
> 
>> On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>>> On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>>>> Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>>>>> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>>>>>> Rationale:
>>>>>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>>>>>> which has nothing to do with XDP.
>> []
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>> []
>>>>>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>>>>>    F:    kernel/bpf/cpumap.c
>>>>>>    F:    kernel/bpf/devmap.c
>>>>>>    F:    net/core/xdp.c
>>>>>> -N:    xdp
>>>>>> -K:    xdp
>>>>>> +N:    (?:\b|_)xdp(?:\b|_)
>>>>>> +K:    (?:\b|_)xdp(?:\b|_)
>>>>>
>>>>> Please also include \W to generally match on non-alphanumeric char given you
>>>>> explicitly want to avoid [a-z0-9] around the term xdp.
>>>> Aren't \W, ^ and $ already covered by \b?
>>>
>>> Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>>> In case this goes via net or net-next tree:
>>
>> This N: pattern does not match files like:
>>
>> 	samples/bpf/xdp1_kern.c
>>
>> and does match files like:
>>
>> 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>>
>> Should it?
> 
> I think the idea is that it should match both?
In *your* opinion: Which of these shall it (not) match?

> 
> -Toke
>
Joe Perches July 10, 2020, 6:42 p.m. UTC | #7 
On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote:
> 
> Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
> > Joe Perches <joe@perches.com> writes:
> > 
> > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
> > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> > > > > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
> > > > > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
> > > > > > > Rationale:
> > > > > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > > > > > > which has nothing to do with XDP.
> > > []
> > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > []
> > > > > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
> > > > > > >    F:    kernel/bpf/cpumap.c
> > > > > > >    F:    kernel/bpf/devmap.c
> > > > > > >    F:    net/core/xdp.c
> > > > > > > -N:    xdp
> > > > > > > -K:    xdp
> > > > > > > +N:    (?:\b|_)xdp(?:\b|_)
> > > > > > > +K:    (?:\b|_)xdp(?:\b|_)
> > > > > > 
> > > > > > Please also include \W to generally match on non-alphanumeric char given you
> > > > > > explicitly want to avoid [a-z0-9] around the term xdp.
> > > > > Aren't \W, ^ and $ already covered by \b?
> > > > 
> > > > Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
> > > > In case this goes via net or net-next tree:
> > > 
> > > This N: pattern does not match files like:
> > > 
> > > 	samples/bpf/xdp1_kern.c
> > > 
> > > and does match files like:
> > > 
> > > 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > > 
> > > Should it?
> > 
> > I think the idea is that it should match both?
> In *your* opinion: Which of these shall it (not) match?

Dunno, but it doesn't match these files.
The first 5 are good, the rest probably should.

$ git ls-files | grep xdp | grep -v -P '(?:\b|_)xdp(?:\b|_)'
Documentation/hwmon/xdpe12284.rst
arch/arm/mach-ixp4xx/ixdp425-pci.c
arch/arm/mach-ixp4xx/ixdp425-setup.c
arch/arm/mach-ixp4xx/ixdpg425-pci.c
drivers/hwmon/pmbus/xdpe12284.c
samples/bpf/xdp1_kern.c
samples/bpf/xdp1_user.c
samples/bpf/xdp2_kern.c
samples/bpf/xdp2skb_meta.sh
samples/bpf/xdp2skb_meta_kern.c
samples/bpf/xdpsock.h
samples/bpf/xdpsock_kern.c
samples/bpf/xdpsock_user.c
tools/testing/selftests/bpf/progs/xdping_kern.c
tools/testing/selftests/bpf/test_xdping.sh
tools/testing/selftests/bpf/xdping.c
tools/testing/selftests/bpf/xdping.h
Toke Høiland-Jørgensen July 10, 2020, 6:57 p.m. UTC | #8 
Joe Perches <joe@perches.com> writes:

> On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote:
>> 
>> Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
>> > Joe Perches <joe@perches.com> writes:
>> > 
>> > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>> > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>> > > > > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> > > > > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> > > > > > > Rationale:
>> > > > > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> > > > > > > which has nothing to do with XDP.
>> > > []
>> > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
>> > > []
>> > > > > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>> > > > > > >    F:    kernel/bpf/cpumap.c
>> > > > > > >    F:    kernel/bpf/devmap.c
>> > > > > > >    F:    net/core/xdp.c
>> > > > > > > -N:    xdp
>> > > > > > > -K:    xdp
>> > > > > > > +N:    (?:\b|_)xdp(?:\b|_)
>> > > > > > > +K:    (?:\b|_)xdp(?:\b|_)
>> > > > > > 
>> > > > > > Please also include \W to generally match on non-alphanumeric char given you
>> > > > > > explicitly want to avoid [a-z0-9] around the term xdp.
>> > > > > Aren't \W, ^ and $ already covered by \b?
>> > > > 
>> > > > Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>> > > > In case this goes via net or net-next tree:
>> > > 
>> > > This N: pattern does not match files like:
>> > > 
>> > > 	samples/bpf/xdp1_kern.c
>> > > 
>> > > and does match files like:
>> > > 
>> > > 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>> > > 
>> > > Should it?
>> > 
>> > I think the idea is that it should match both?
>> In *your* opinion: Which of these shall it (not) match?
>
> Dunno, but it doesn't match these files.
> The first 5 are good, the rest probably should.

Yup, I agree, all but the first 5 should be matched...

-Toke

> $ git ls-files | grep xdp | grep -v -P '(?:\b|_)xdp(?:\b|_)'
> Documentation/hwmon/xdpe12284.rst
> arch/arm/mach-ixp4xx/ixdp425-pci.c
> arch/arm/mach-ixp4xx/ixdp425-setup.c
> arch/arm/mach-ixp4xx/ixdpg425-pci.c
> drivers/hwmon/pmbus/xdpe12284.c
> samples/bpf/xdp1_kern.c
> samples/bpf/xdp1_user.c
> samples/bpf/xdp2_kern.c
> samples/bpf/xdp2skb_meta.sh
> samples/bpf/xdp2skb_meta_kern.c
> samples/bpf/xdpsock.h
> samples/bpf/xdpsock_kern.c
> samples/bpf/xdpsock_user.c
> tools/testing/selftests/bpf/progs/xdping_kern.c
> tools/testing/selftests/bpf/test_xdping.sh
> tools/testing/selftests/bpf/xdping.c
> tools/testing/selftests/bpf/xdping.h
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 1d4aa7f942de..2bb7feb838af 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18708,8 +18708,8 @@  F:	include/trace/events/xdp.h
 F:	kernel/bpf/cpumap.c
 F:	kernel/bpf/devmap.c
 F:	net/core/xdp.c
-N:	xdp
-K:	xdp
+N:	(?:\b|_)xdp(?:\b|_)
+K:	(?:\b|_)xdp(?:\b|_)
 
 XDP SOCKETS (AF_XDP)
 M:	Björn Töpel <bjorn.topel@intel.com>