| Message ID | 20200707074121.230686-1-vaibhavgupta40@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] sun/niu: add __maybe_unused attribute to PM functions | expand |
From: Vaibhav Gupta <vaibhavgupta40@gmail.com> Date: Tue, 7 Jul 2020 13:11:22 +0530 > The upgraded .suspend() and .resume() throw > "defined but not used [-Wunused-function]" warning for certain > configurations. > > Mark them with "__maybe_unused" attribute. > > Compile-tested only. > > Fixes: b0db0cc2f695 ("sun/niu: use generic power management") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> Applied.
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 68541c823245..b4e20d15d138 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -9873,7 +9873,7 @@ static void niu_pci_remove_one(struct pci_dev *pdev) } } -static int niu_suspend(struct device *dev_d) +static int __maybe_unused niu_suspend(struct device *dev_d) { struct net_device *dev = dev_get_drvdata(dev_d); struct niu *np = netdev_priv(dev); @@ -9900,7 +9900,7 @@ static int niu_suspend(struct device *dev_d) return 0; } -static int niu_resume(struct device *dev_d) +static int __maybe_unused niu_resume(struct device *dev_d) { struct net_device *dev = dev_get_drvdata(dev_d); struct niu *np = netdev_priv(dev);
The upgraded .suspend() and .resume() throw "defined but not used [-Wunused-function]" warning for certain configurations. Mark them with "__maybe_unused" attribute. Compile-tested only. Fixes: b0db0cc2f695 ("sun/niu: use generic power management") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> --- drivers/net/ethernet/sun/niu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)