mbox series

[net,0/2] net: rmnet: fix interface leak for rmnet module

Message ID 20200702170737.10479-1-ap420073@gmail.com
Headers show
Series net: rmnet: fix interface leak for rmnet module | expand

Message

Taehee Yoo July 2, 2020, 5:07 p.m. UTC 
There are two problems in rmnet module that they occur the leak of
a lower interface.
The symptom is the same, which is the leak of a lower interface.
But there are two different real problems.
This patchset is to fix these real problems.

1. Do not allow to have different two modes.
As a lower interface of rmnet, there are two modes that they are VND
and BRIDGE.
One interface can have only one mode.
But in the current rmnet, there is no code to prevent to have
two modes in one lower interface.
So, interface leak occurs.

2. Do not allow to add multiple bridge interfaces.
rmnet can have only two bridge interface.
If an additional bridge interface is tried to be attached,
rmnet should deny it.
But there is no code to do that.
So, interface leak occurs.

Taehee Yoo (2):
  net: rmnet: fix lower interface leak
  net: rmnet: do not allow to add multiple bridge interfaces

 .../net/ethernet/qualcomm/rmnet/rmnet_config.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

Comments

Subash Abhinov Kasiviswanathan July 3, 2020, 4:01 a.m. UTC | #1 
On 2020-07-02 11:07, Taehee Yoo wrote:
> There are two problems in rmnet module that they occur the leak of
> a lower interface.
> The symptom is the same, which is the leak of a lower interface.
> But there are two different real problems.
> This patchset is to fix these real problems.
> 
> 1. Do not allow to have different two modes.
> As a lower interface of rmnet, there are two modes that they are VND
> and BRIDGE.
> One interface can have only one mode.
> But in the current rmnet, there is no code to prevent to have
> two modes in one lower interface.
> So, interface leak occurs.
> 
> 2. Do not allow to add multiple bridge interfaces.
> rmnet can have only two bridge interface.
> If an additional bridge interface is tried to be attached,
> rmnet should deny it.
> But there is no code to do that.
> So, interface leak occurs.
> 
> Taehee Yoo (2):
>   net: rmnet: fix lower interface leak
>   net: rmnet: do not allow to add multiple bridge interfaces
> 
>  .../net/ethernet/qualcomm/rmnet/rmnet_config.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)

Thanks Taehee. For the series-

Reviewed-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
David Miller July 5, 2020, 1:05 a.m. UTC | #2 
From: Taehee Yoo <ap420073@gmail.com>
Date: Thu,  2 Jul 2020 17:07:37 +0000

> There are two problems in rmnet module that they occur the leak of
> a lower interface.
> The symptom is the same, which is the leak of a lower interface.
> But there are two different real problems.
> This patchset is to fix these real problems.
> 
> 1. Do not allow to have different two modes.
> As a lower interface of rmnet, there are two modes that they are VND
> and BRIDGE.
> One interface can have only one mode.
> But in the current rmnet, there is no code to prevent to have
> two modes in one lower interface.
> So, interface leak occurs.
> 
> 2. Do not allow to add multiple bridge interfaces.
> rmnet can have only two bridge interface.
> If an additional bridge interface is tried to be attached,
> rmnet should deny it.
> But there is no code to do that.
> So, interface leak occurs.

Series applied and queued up for v5.6+ -stable, thanks.