diff mbox series

sparc: sparc64_defconfig: add necessary configs for qemu

Message ID 1593694973-34113-1-git-send-email-clabbe@baylibre.com
State Changes Requested
Delegated to: David Miller
Headers show
Series sparc: sparc64_defconfig: add necessary configs for qemu | expand

Commit Message

Corentin LABBE July 2, 2020, 1:02 p.m. UTC
The sparc64 qemu machines uses pcnet32 network hardware by default, so for
simple boot testing using qemu, having PCNET32 is useful.
Same for its storage which is a PATA_CMD64.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/sparc/configs/sparc64_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Julian Calaby July 2, 2020, 1:27 p.m. UTC | #1
Hi Corentin,

On Thu, Jul 2, 2020 at 11:03 PM Corentin Labbe <clabbe@baylibre.com> wrote:
>
> The sparc64 qemu machines uses pcnet32 network hardware by default, so for
> simple boot testing using qemu, having PCNET32 is useful.
> Same for its storage which is a PATA_CMD64.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  arch/sparc/configs/sparc64_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/sparc/configs/sparc64_defconfig b/arch/sparc/configs/sparc64_defconfig
> index bde4d21a8ac8..61073f48a7a1 100644
> --- a/arch/sparc/configs/sparc64_defconfig
> +++ b/arch/sparc/configs/sparc64_defconfig
> @@ -236,3 +236,6 @@ CONFIG_CRYPTO_TWOFISH=m
>  CONFIG_CRC16=m
>  CONFIG_LIBCRC32C=m
>  CONFIG_VCC=m
> +CONFIG_ATA=y
> +CONFIG_PATA_CMD64X=y
> +CONFIG_PCNET32=y

FWIW the CMD640 is the IDE controller used on the Ultra 5/10 machines.

Thanks,
Mark Cave-Ayland July 2, 2020, 7:58 p.m. UTC | #2
On 02/07/2020 14:02, Corentin Labbe wrote:

> The sparc64 qemu machines uses pcnet32 network hardware by default, so for
> simple boot testing using qemu, having PCNET32 is useful.
> Same for its storage which is a PATA_CMD64.

Which version of QEMU are you using? qemu-system-sparc64 switched to using a hme NIC
by default in version 2.11 (see
https://wiki.qemu.org/Documentation/Platforms/SPARC#Changes_to_sun4u_machine_from_2.11_onwards)
which is well over 2 years ago...


ATB,

Mark.
Corentin LABBE July 3, 2020, 5:55 a.m. UTC | #3
On Thu, Jul 02, 2020 at 08:58:40PM +0100, Mark Cave-Ayland wrote:
> On 02/07/2020 14:02, Corentin Labbe wrote:
> 
> > The sparc64 qemu machines uses pcnet32 network hardware by default, so for
> > simple boot testing using qemu, having PCNET32 is useful.
> > Same for its storage which is a PATA_CMD64.
> 
> Which version of QEMU are you using? qemu-system-sparc64 switched to using a hme NIC
> by default in version 2.11 (see
> https://wiki.qemu.org/Documentation/Platforms/SPARC#Changes_to_sun4u_machine_from_2.11_onwards)
> which is well over 2 years ago...
> 

You are right, I verfied in the code and it is sunhme by default.
So I will verify it works and send a v2.
diff mbox series

Patch

diff --git a/arch/sparc/configs/sparc64_defconfig b/arch/sparc/configs/sparc64_defconfig
index bde4d21a8ac8..61073f48a7a1 100644
--- a/arch/sparc/configs/sparc64_defconfig
+++ b/arch/sparc/configs/sparc64_defconfig
@@ -236,3 +236,6 @@  CONFIG_CRYPTO_TWOFISH=m
 CONFIG_CRC16=m
 CONFIG_LIBCRC32C=m
 CONFIG_VCC=m
+CONFIG_ATA=y
+CONFIG_PATA_CMD64X=y
+CONFIG_PCNET32=y