| Message ID | 20200628185522.5902-1-wsa+renesas@sang-engineering.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i2c: add Kconfig help text for slave mode | expand |
Hi Wolfram, Thanks for your patch. On 2020-06-28 20:55:22 +0200, Wolfram Sang wrote: > I can't recall why there was none, but we surely want to have it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/i2c/Kconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > index dbcbb8a6024e..e2d6063bdb4d 100644 > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -114,6 +114,11 @@ config I2C_STUB > config I2C_SLAVE > bool "I2C slave support" > > + help > + This enables Linux to act as an I2C slave device. Note that your I2C > + bus master driver also needs to support this functionality. Please > + read Documentation/i2c/slave-interface.rst for further details. > + > if I2C_SLAVE > > config I2C_SLAVE_EEPROM > -- > 2.20.1 >
Hi Wolfram, On Sun, Jun 28, 2020 at 8:55 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > I can't recall why there was none, but we surely want to have it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -114,6 +114,11 @@ config I2C_STUB > config I2C_SLAVE > bool "I2C slave support" > Why the blank line here ^^^? > + help > + This enables Linux to act as an I2C slave device. Note that your I2C > + bus master driver also needs to support this functionality. Please > + read Documentation/i2c/slave-interface.rst for further details. > + > if I2C_SLAVE > > config I2C_SLAVE_EEPROM The rest looks fine to me. As you don't like conditional R-b's, I'll add mine on v2 ;-) Gr{oetje,eeting}s, Geert
> > config I2C_SLAVE > > bool "I2C slave support" > > > > Why the blank line here ^^^? Sure, I can fix before applying. > > > + help > > + This enables Linux to act as an I2C slave device. Note that your I2C > > + bus master driver also needs to support this functionality. Please > > + read Documentation/i2c/slave-interface.rst for further details. > > + > > if I2C_SLAVE > > > > config I2C_SLAVE_EEPROM > > The rest looks fine to me. Thanks, Geert! > As you don't like conditional R-b's, I'll add mine on v2 ;-) I don't? I can't recall that :) Maybe there was a corner case once...
Hi Wolfram, On Mon, Jun 29, 2020 at 1:21 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > > config I2C_SLAVE > > > bool "I2C slave support" > > > > > > > Why the blank line here ^^^? > > Sure, I can fix before applying. > > > > > > + help > > > + This enables Linux to act as an I2C slave device. Note that your I2C > > > + bus master driver also needs to support this functionality. Please > > > + read Documentation/i2c/slave-interface.rst for further details. > > > + > > > if I2C_SLAVE > > > > > > config I2C_SLAVE_EEPROM > > > > The rest looks fine to me. > > Thanks, Geert! > > > As you don't like conditional R-b's, I'll add mine on v2 ;-) > > I don't? I can't recall that :) Maybe there was a corner case once... Lore does not forgive, and does not forget ;-) https://lore.kernel.org/r/20190802133656.GA23542@kunai Hence with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
> Lore does not forgive, and does not forget ;-) > https://lore.kernel.org/r/20190802133656.GA23542@kunai Ah, right. That reasoning still makes sense to me.
On Sun, Jun 28, 2020 at 08:55:22PM +0200, Wolfram Sang wrote: > I can't recall why there was none, but we surely want to have it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index dbcbb8a6024e..e2d6063bdb4d 100644 --- a/drivers/i2c/Kconfig +++ b/drivers/i2c/Kconfig @@ -114,6 +114,11 @@ config I2C_STUB config I2C_SLAVE bool "I2C slave support" + help + This enables Linux to act as an I2C slave device. Note that your I2C + bus master driver also needs to support this functionality. Please + read Documentation/i2c/slave-interface.rst for further details. + if I2C_SLAVE config I2C_SLAVE_EEPROM
I can't recall why there was none, but we surely want to have it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)