mbox series

[v1,0/2] ipw2x00: use generic power management

Message ID 20200629033226.160936-1-vaibhavgupta40@gmail.com
Headers show
Series ipw2x00: use generic power management | expand

Message

Vaibhav Gupta June 29, 2020, 3:32 a.m. UTC 
Linux Kernel Mentee: Remove Legacy Power Management.

The purpose of this patch series is to remove legacy power management callbacks
from amd ethernet drivers.

The callbacks performing suspend() and resume() operations are still calling
pci_save_state(), pci_set_power_state(), etc. and handling the power management
themselves, which is not recommended.

The conversion requires the removal of the those function calls and change the
callback definition accordingly and make use of dev_pm_ops structure.

All patches are compile-tested only.

Vaibhav Gupta (2):
  ipw2100: use generic power management
  ipw2200: use generic power management

 drivers/net/wireless/intel/ipw2x00/ipw2100.c | 31 +++++---------------
 drivers/net/wireless/intel/ipw2x00/ipw2200.c | 30 +++++--------------
 2 files changed, 14 insertions(+), 47 deletions(-)

Comments

Vaibhav Gupta June 29, 2020, 7:13 a.m. UTC | #1 
On Mon, 29 Jun 2020 at 11:20, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Vaibhav Gupta <vaibhavgupta40@gmail.com> writes:
>
> > Linux Kernel Mentee: Remove Legacy Power Management.
> >
> > The purpose of this patch series is to remove legacy power management callbacks
> > from amd ethernet drivers.
> >
> > The callbacks performing suspend() and resume() operations are still calling
> > pci_save_state(), pci_set_power_state(), etc. and handling the power management
> > themselves, which is not recommended.
> >
> > The conversion requires the removal of the those function calls and change the
> > callback definition accordingly and make use of dev_pm_ops structure.
> >
> > All patches are compile-tested only.
> >
> > Vaibhav Gupta (2):
> >   ipw2100: use generic power management
> >   ipw2200: use generic power management
> >
> >  drivers/net/wireless/intel/ipw2x00/ipw2100.c | 31 +++++---------------
> >  drivers/net/wireless/intel/ipw2x00/ipw2200.c | 30 +++++--------------
> >  2 files changed, 14 insertions(+), 47 deletions(-)
>
> For wireless patches you should CC linux-wireless, otherwise they will
> not be in radar.
Oh yes, sorry! My mistake, I missed CCing them. Sending it again!
> See more from link below.
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches