mbox series

[net,0/2] tcp_cubic: fix spurious HYSTART_DELAY on RTT decrease

Message ID 20200624164203.183122-1-ncardwell@google.com
Headers show
Series tcp_cubic: fix spurious HYSTART_DELAY on RTT decrease | expand

Message

Neal Cardwell June 24, 2020, 4:42 p.m. UTC
This series fixes a long-standing bug in the TCP CUBIC
HYSTART_DELAY mechanim recently reported by Mirja Kuehlewind. The
code can cause a spurious exit of slow start in some particular
cases: upon an RTT decrease that happens on the 9th or later ACK
in a round trip. This series fixes the original Hystart code and
also the recent BPF implementation.

Neal Cardwell (2):
  tcp_cubic: fix spurious HYSTART_DELAY exit upon drop in min RTT
  bpf: tcp: bpf_cubic: fix spurious HYSTART_DELAY exit upon drop in min
    RTT

 net/ipv4/tcp_cubic.c                          | 5 ++---
 tools/testing/selftests/bpf/progs/bpf_cubic.c | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

Comments

David Miller June 25, 2020, 11:09 p.m. UTC | #1
From: Neal Cardwell <ncardwell@google.com>
Date: Wed, 24 Jun 2020 12:42:01 -0400

> This series fixes a long-standing bug in the TCP CUBIC
> HYSTART_DELAY mechanim recently reported by Mirja Kuehlewind. The
> code can cause a spurious exit of slow start in some particular
> cases: upon an RTT decrease that happens on the 9th or later ACK
> in a round trip. This series fixes the original Hystart code and
> also the recent BPF implementation.

Series applied and queued up for -stable, thank you.