mbox series

[v2,0/2] cifs: Fix data insonsistent when fallocate

Message ID 20200623113154.2629513-1-zhangxiaoxu5@huawei.com
Headers show
Series cifs: Fix data insonsistent when fallocate | expand

Message

zhangxiaoxu (A) June 23, 2020, 11:31 a.m. UTC
*** BLURB HERE ***
v1->v2: 
  1. add fixes and cc:stable
  2. punch hole fix address xfstests generic/316 failed

Zhang Xiaoxu (2):
  cifs/smb3: Fix data inconsistent when punch hole
  cifs/smb3: Fix data inconsistent when zero file range

 fs/cifs/smb2ops.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Steve French June 23, 2020, 5:17 p.m. UTC | #1
merged the four patches into cifs-2.6.git for-next and running tests now

FYI - the git commit ids referenced in the patch descriptions
(although they appear correct) are not in a form that checkpatch
recognizes.  I ignored that warning since the ids are correct.
Probably not worth changing but FYI for future patches.

Thx - these look helpful.   I will try to update the xfstesting
cifs.ko wiki page on Samba.org with the results ... there are probably
another 10+ xfstests we can add to the buildbot beyond these
(especially with modefromsid/idsfromsid and with swap over smb3 mounts
etc.).  There are also additional tests that could be enabled with
changesets to allow more fallocate options to be supported

On Tue, Jun 23, 2020 at 6:33 AM Zhang Xiaoxu <zhangxiaoxu5@huawei.com> wrote:
>
> *** BLURB HERE ***
> v1->v2:
>   1. add fixes and cc:stable
>   2. punch hole fix address xfstests generic/316 failed
>
> Zhang Xiaoxu (2):
>   cifs/smb3: Fix data inconsistent when punch hole
>   cifs/smb3: Fix data inconsistent when zero file range
>
>  fs/cifs/smb2ops.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> --
> 2.25.4
>
Pavel Shilovsky June 23, 2020, 7:01 p.m. UTC | #2
вт, 23 июн. 2020 г. в 04:30, Zhang Xiaoxu <zhangxiaoxu5@huawei.com>:
>
> *** BLURB HERE ***
> v1->v2:
>   1. add fixes and cc:stable
>   2. punch hole fix address xfstests generic/316 failed
>
> Zhang Xiaoxu (2):
>   cifs/smb3: Fix data inconsistent when punch hole
>   cifs/smb3: Fix data inconsistent when zero file range
>
>  fs/cifs/smb2ops.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> --
> 2.25.4
>

Thanks for fixing the punch hole code path too!

Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

--
Best regards,
Pavel Shilovsky