Message ID | 20200619161813.2716-1-dmurphy@ti.com |
---|---|
Headers | show |
Series | RGMII Internal delay common property | expand |
From: Dan Murphy <dmurphy@ti.com> Date: Fri, 19 Jun 2020 11:18:10 -0500 > +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev, > + const int *delay_values, int size, bool is_rx) > +{ > + int i; > + s32 delay; Please use reverse christmas tree ordering for local variables.
David On 6/22/20 5:40 PM, David Miller wrote: > From: Dan Murphy <dmurphy@ti.com> > Date: Fri, 19 Jun 2020 11:18:10 -0500 > >> +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev, >> + const int *delay_values, int size, bool is_rx) >> +{ >> + int i; >> + s32 delay; > Please use reverse christmas tree ordering for local variables. OK. Dan