| Message ID | HPTrw9hrtm3e5151oH8oQfbr0HWTlzQ1n68bZn1hfd6yag38Tem57b4eTH-bhlaJgBxyhZb9U-qFFOafJoQqxcY-VX5fh5ZktTrnWhYeNB0=@pm.me |
|---|---|
| Headers | show |
| Series | net: ethtool: netdev_features_strings[] cleanup | expand |
From: Alexander Lobakin <alobakin@pm.me> Date: Sun, 21 Jun 2020 09:55:50 +0000 > This little series adds the last forgotten feature string for > NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses > in future. > > Patches 2-3 seem more like net-next candidates rather than net-fixes, > but for me it seems a bit more suitable to pull it during "quiet" RC > windows, so any new related code could start from this base. > > I was thinking about some kind of static assertion to have an early > prevention mechanism for this, but the existing of 2 intended holes > (former NO_CSUM and UFO) makes this problematic, at least at first > sight. > > v2: > - fix the "Fixes:" tag in the first patch; > - no functional changes. Please do not mix bug fixes (missing netdev feature strings, etc.) with cleanups (indentation changes). Thank you.
Hi Dave, Michal, On Tuesday, 23 June 2020, 2:34, David Miller <davem@davemloft.net> wrote: > From: Alexander Lobakin <alobakin@pm.me> > Date: Sun, 21 Jun 2020 09:55:50 +0000 > > This little series adds the last forgotten feature string for > > NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses > > in future. > > > > Patches 2-3 seem more like net-next candidates rather than net-fixes, > > but for me it seems a bit more suitable to pull it during "quiet" RC > > windows, so any new related code could start from this base. > > > > I was thinking about some kind of static assertion to have an early > > prevention mechanism for this, but the existing of 2 intended holes > > (former NO_CSUM and UFO) makes this problematic, at least at first > > sight. > > > > v2: > > - fix the "Fixes:" tag in the first patch; > > - no functional changes. > > Please do not mix bug fixes (missing netdev feature strings, etc.) with > cleanups (indentation changes). You both are right, I should've thought better about that. I'll split the series into two and resend, sorry. > Thank you. Thanks, Al
This little series adds the last forgotten feature string for NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses in future. Patches 2-3 seem more like net-next candidates rather than net-fixes, but for me it seems a bit more suitable to pull it during "quiet" RC windows, so any new related code could start from this base. I was thinking about some kind of static assertion to have an early prevention mechanism for this, but the existing of 2 intended holes (former NO_CSUM and UFO) makes this problematic, at least at first sight. v2: - fix the "Fixes:" tag in the first patch; - no functional changes. Alexander Lobakin (3): net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM net: ethtool: fix indentation of netdev_features_strings net: ethtool: sync netdev_features_strings order with enum netdev_features net/ethtool/common.c | 133 ++++++++++++++++++++++++------------------- 1 file changed, 74 insertions(+), 59 deletions(-)