Message ID | 20200622093744.13685-5-brgl@bgdev.pl |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | net: phy: correctly model the PHY voltage supply in DT | expand |
On Mon, Jun 22, 2020 at 11:37:33AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This header refers to struct reset_control but doesn't include any reset > header. The structure definition is probably somehow indirectly pulled in > since no warnings are reported but for the sake of correctness add the > forward declaration for struct reset_control. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This header refers to struct reset_control but doesn't include any reset > header. The structure definition is probably somehow indirectly pulled in > since no warnings are reported but for the sake of correctness add the > forward declaration for struct reset_control. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > include/linux/mdio.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/mdio.h b/include/linux/mdio.h > index 36d2e0673d03..9ac5e7ff6156 100644 > --- a/include/linux/mdio.h > +++ b/include/linux/mdio.h > @@ -17,6 +17,7 @@ > #define MII_REGADDR_C45_MASK GENMASK(15, 0) > > struct gpio_desc; > +struct reset_control; > struct mii_bus; You wrote 3 patches to sort the headers alphabetically, do you mind doing the same thing for forward declarations as well?
diff --git a/include/linux/mdio.h b/include/linux/mdio.h index 36d2e0673d03..9ac5e7ff6156 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -17,6 +17,7 @@ #define MII_REGADDR_C45_MASK GENMASK(15, 0) struct gpio_desc; +struct reset_control; struct mii_bus; /* Multiple levels of nesting are possible. However typically this is