| Message ID | cover.1592289629.git.geliangtang@gmail.com |
|---|---|
| Headers | show |
| Series | add MP_PRIO, MP_FAIL and MP_FASTCLOSE suboptions handling | expand |
Hi Geliang On 16/06/2020 08:47, Geliang Tang wrote: > Add handling for sending and receiving the MP_PRIO, MP_FAIL, and > MP_FASTCLOSE suboptions. Thank you for the patches! Unfortunately, I don't think it would be wise to accept them now: for the moment, these suboptions are ignored at the reception. If we accept them and change some variables like you did, we would need to make sure the kernel is still acting correctly. In other words, we would need tests: * For MP_PRIO, there are still quite some works to do regarding the scheduling of the packets between the different MPTCP subflows to do before supporting this. * For MP_FAIL, we should forward the info to the path manager. * For MP_FASTCLOSE, we should close connections and ACK this. Also, net-next is closed for the moment: http://vger.kernel.org/~davem/net-next.html I would suggest you to discuss about that on MPTCP mailing list. We also have meetings every Thursday. New devs are always welcome to contribute to new features and bug-fixes! Cheers, Matt
On Tue, Jun 16, 2020 at 05:18:56PM +0200, Matthieu Baerts wrote: > Hi Geliang > > On 16/06/2020 08:47, Geliang Tang wrote: > > Add handling for sending and receiving the MP_PRIO, MP_FAIL, and > > MP_FASTCLOSE suboptions. > > Thank you for the patches! > > Unfortunately, I don't think it would be wise to accept them now: for the > moment, these suboptions are ignored at the reception. If we accept them and > change some variables like you did, we would need to make sure the kernel is > still acting correctly. In other words, we would need tests: > * For MP_PRIO, there are still quite some works to do regarding the > scheduling of the packets between the different MPTCP subflows to do before > supporting this. > * For MP_FAIL, we should forward the info to the path manager. > * For MP_FASTCLOSE, we should close connections and ACK this. > > Also, net-next is closed for the moment: > http://vger.kernel.org/~davem/net-next.html > > I would suggest you to discuss about that on MPTCP mailing list. We also > have meetings every Thursday. New devs are always welcome to contribute to > new features and bug-fixes! > Hi Matt, Thanks for your reply. I will do these tests and improve my patches. -Geliang > Cheers, > Matt > -- > Tessares | Belgium | Hybrid Access Solutions > www.tessares.net
Hi Geliang, On 18/06/2020 08:27, Geliang Tang wrote: > On Tue, Jun 16, 2020 at 05:18:56PM +0200, Matthieu Baerts wrote: >> On 16/06/2020 08:47, Geliang Tang wrote: >> >> I would suggest you to discuss about that on MPTCP mailing list. We also >> have meetings every Thursday. New devs are always welcome to contribute to >> new features and bug-fixes! > > Thanks for your reply. I will do these tests and improve my patches. Great, thank you! Looking forward to see new kernel selftests and/or packetdrill tests! For any new features related to MPTCP or bug fixes involving significant code modifications, please send it first to the MPTCP Upstream mailing list only: mptcp@lists.01.org We will be able to give a first review without involving the whole netdev community and if needed, we can "park" patches in our mptcp-next repo. For more details about the project, please check: https://github.com/multipath-tcp/mptcp_net-next/wiki Cheers, Matt