mbox series

[v3,0/3] pinctrl: intel: Reuse for_each_requested_gpio*() macros

Message ID 20200615151353.88194-1-andriy.shevchenko@linux.intel.com
Headers show
Series pinctrl: intel: Reuse for_each_requested_gpio*() macros | expand

Message

Andy Shevchenko June 15, 2020, 3:13 p.m. UTC 
This is part of previously sent clean up / fixes series against Intel pin
control drivers. This piece replaces home grown alternatives to generic (*)
for_each_requested_gpio*() helpers.

(*) Mika suggested to document for_each_requested_gpio*() helper, and I decided
that it may be useful to GPIO and pin control subsystems in general, so, thus it
has dependency to [1] submitted recently.

[1]: https://lore.kernel.org/linux-gpio/20200615150545.87964-1-andriy.shevchenko@linux.intel.com/T/#t

Andy Shevchenko (3):
  pinctrl: intel: Make use of for_each_requested_gpio_in_range()
  pinctrl: lynxpoint: Make use of for_each_requested_gpio()
  pinctrl: lynxpoint: Introduce helpers to enable or disable input

 drivers/pinctrl/intel/pinctrl-intel.c     | 21 ++++++------------
 drivers/pinctrl/intel/pinctrl-lynxpoint.c | 26 +++++++++++++++--------
 2 files changed, 23 insertions(+), 24 deletions(-)

Comments

Mika Westerberg June 15, 2020, 4:33 p.m. UTC | #1 
On Mon, Jun 15, 2020 at 06:13:50PM +0300, Andy Shevchenko wrote:
> This is part of previously sent clean up / fixes series against Intel pin
> control drivers. This piece replaces home grown alternatives to generic (*)
> for_each_requested_gpio*() helpers.
> 
> (*) Mika suggested to document for_each_requested_gpio*() helper, and I decided
> that it may be useful to GPIO and pin control subsystems in general, so, thus it
> has dependency to [1] submitted recently.
> 
> [1]: https://lore.kernel.org/linux-gpio/20200615150545.87964-1-andriy.shevchenko@linux.intel.com/T/#t
> 
> Andy Shevchenko (3):
>   pinctrl: intel: Make use of for_each_requested_gpio_in_range()
>   pinctrl: lynxpoint: Make use of for_each_requested_gpio()
>   pinctrl: lynxpoint: Introduce helpers to enable or disable input

Looks good,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>