diff mbox series

[v2,6/7] libpdbg: If device path does not exist, log at INFO level

Message ID 20200610052426.150225-7-amitay@ozlabs.org
State Accepted
Headers show
Series Make kernel fsi driver generic | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (86851b290ac1771b9a6fb0d5238ebf459ea80a21)
snowpatch_ozlabs/build-multiarch success Test build-multiarch on branch master

Commit Message

Amitay Isaacs June 10, 2020, 5:24 a.m. UTC 
Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
---
 libpdbg/kernel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alistair Popple June 15, 2020, 7:32 a.m. UTC | #1 
Thanks for fixing. Probe gets called in contexts where failure is expected so 
there should never be errors there.

Reviewed-by: Alistair Popple <alistair@popple.id.au>

On Wednesday, 10 June 2020 3:24:25 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
> ---
>  libpdbg/kernel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libpdbg/kernel.c b/libpdbg/kernel.c
> index c63ef93..b2b977b 100644
> --- a/libpdbg/kernel.c
> +++ b/libpdbg/kernel.c
> @@ -186,7 +186,7 @@ int kernel_fsi_probe(struct pdbg_target *target)
>  		}
>  	}
>  
> -	PR_ERROR("Unable to open %s\n", path);
> +	PR_INFO("Unable to open %s\n", path);
>  	free(path);
>  	return -1;
>  }
> @@ -250,7 +250,7 @@ static int kernel_pib_probe(struct pdbg_target *target)
>  
>  	pib->fd = open(scom_path, O_RDWR | O_SYNC);
>  	if (pib->fd < 0) {
> -		PR_ERROR("Unable to open %s\n", scom_path);
> +		PR_INFO("Unable to open %s\n", scom_path);
>  		return -1;
>  	}
>  
>
diff mbox series

Patch

diff --git a/libpdbg/kernel.c b/libpdbg/kernel.c
index c63ef93..b2b977b 100644
--- a/libpdbg/kernel.c
+++ b/libpdbg/kernel.c
@@ -186,7 +186,7 @@  int kernel_fsi_probe(struct pdbg_target *target)
 		}
 	}
 
-	PR_ERROR("Unable to open %s\n", path);
+	PR_INFO("Unable to open %s\n", path);
 	free(path);
 	return -1;
 }
@@ -250,7 +250,7 @@  static int kernel_pib_probe(struct pdbg_target *target)
 
 	pib->fd = open(scom_path, O_RDWR | O_SYNC);
 	if (pib->fd < 0) {
-		PR_ERROR("Unable to open %s\n", scom_path);
+		PR_INFO("Unable to open %s\n", scom_path);
 		return -1;
 	}