Message ID | 20200604111410.17918-1-dmurphy@ti.com |
---|---|
Headers | show |
Series | RGMII Internal delay common property | expand |
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: > Add RGMII internal delay configuration for Rx and Tx. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> Hi Dan, please make sure W=1 C=1 build is clean: drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-const-variable=] 103 | static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500, | ^~~~~~~~~~~~~~~~~~~~~~ Also net-next is closed right now, you can post RFCs but normal patches should be deferred until after net-next reopens.
Jakub On 6/4/20 11:25 AM, Jakub Kicinski wrote: > On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: >> Add RGMII internal delay configuration for Rx and Tx. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> > Hi Dan, please make sure W=1 C=1 build is clean: > > drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-const-variable=] > 103 | static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500, > | ^~~~~~~~~~~~~~~~~~~~~~ I built with W=1 and C=1 and did not see this warning. What defconfig are you using? Can you check if CONFIG_OF_MDIO is set or not? That would be the only way that warning would come up. > Also net-next is closed right now, you can post RFCs but normal patches > should be deferred until after net-next reopens. I know net-next is closed. I pinged David M when it was open about what is meant by "new" patches in the net-dev FAQ. So I figured I would send the patches to see what the response was. To me these are not new they are in process patches. My understand is New is v1 patchesets. But now I have the answer. Dan
On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote: > Jakub > > On 6/4/20 11:25 AM, Jakub Kicinski wrote: > > On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: > >> Add RGMII internal delay configuration for Rx and Tx. > >> > >> Signed-off-by: Dan Murphy <dmurphy@ti.com> > > Hi Dan, please make sure W=1 C=1 build is clean: > > > > drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-const-variable=] > > 103 | static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500, > > | ^~~~~~~~~~~~~~~~~~~~~~ > > I built with W=1 and C=1 and did not see this warning. > > What defconfig are you using? allmodconfig with gcc-10 > Can you check if CONFIG_OF_MDIO is set or not? That would be the only > way that warning would come up. Hm. I don't have the config from this particular build but just running allmodconfig makes it CONFIG_OF_MDIO=m > > Also net-next is closed right now, you can post RFCs but normal patches > > should be deferred until after net-next reopens. > > I know net-next is closed. > > I pinged David M when it was open about what is meant by "new" patches > in the net-dev FAQ. So I figured I would send the patches to see what > the response was. > > To me these are not new they are in process patches. My understand is > New is v1 patchesets. > > But now I have the answer. Oh sorry, I may be wrong in this case, I haven't tracked this series.
Jakub On 6/4/20 11:48 AM, Jakub Kicinski wrote: > On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote: >> Jakub >> >> On 6/4/20 11:25 AM, Jakub Kicinski wrote: >>> On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: >>>> Add RGMII internal delay configuration for Rx and Tx. >>>> >>>> Signed-off-by: Dan Murphy <dmurphy@ti.com> >>> Hi Dan, please make sure W=1 C=1 build is clean: >>> >>> drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-const-variable=] >>> 103 | static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500, >>> | ^~~~~~~~~~~~~~~~~~~~~~ >> I built with W=1 and C=1 and did not see this warning. >> >> What defconfig are you using? > allmodconfig with gcc-10 > >> Can you check if CONFIG_OF_MDIO is set or not? That would be the only >> way that warning would come up. > Hm. I don't have the config from this particular build but just running > allmodconfig makes it CONFIG_OF_MDIO=m OK that makes sense then. That is an existing bug that shows up because of this. #ifdef CONFIG_OF_MDIO So the addition of the array exposed an existing issue. That bug fix can go to net then. >>> Also net-next is closed right now, you can post RFCs but normal patches >>> should be deferred until after net-next reopens. >> I know net-next is closed. >> >> I pinged David M when it was open about what is meant by "new" patches >> in the net-dev FAQ. So I figured I would send the patches to see what >> the response was. >> >> To me these are not new they are in process patches. My understand is >> New is v1 patchesets. >> >> But now I have the answer. > Oh sorry, I may be wrong in this case, I haven't tracked this series. > It says v6 in $subject. But still you may be correct I don't know Dan