| Message ID | 1590809673-105923-1-git-send-email-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] devinet: fix memleak in inetdev_init() | expand |
On Fri, May 29, 2020 at 8:11 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > > When devinet_sysctl_register() failed, the memory allocated > in neigh_parms_alloc() should be freed. > > Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Thanks.
From: Yang Yingliang <yangyingliang@huawei.com> Date: Sat, 30 May 2020 11:34:33 +0800 > When devinet_sysctl_register() failed, the memory allocated > in neigh_parms_alloc() should be freed. > > Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Applied and queued up for -stable, thanks.
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index c0dd561..5267b6b 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -276,6 +276,7 @@ static struct in_device *inetdev_init(struct net_device *dev) err = devinet_sysctl_register(in_dev); if (err) { in_dev->dead = 1; + neigh_parms_release(&arp_tbl, in_dev->arp_parms); in_dev_put(in_dev); in_dev = NULL; goto out;
When devinet_sysctl_register() failed, the memory allocated in neigh_parms_alloc() should be freed. Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- net/ipv4/devinet.c | 1 + 1 file changed, 1 insertion(+)