Message ID | 20200530203404.1665-1-michael@walle.cc |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [net-next] net: phy: broadcom: don't export RDB/legacy access methods | expand |
On 5/30/2020 1:34 PM, Michael Walle wrote: > Don't export __bcm_phy_enable_rdb_access() and > __bcm_phy_enable_legacy_access() functions. They aren't used outside this > module and it was forgotten to provide a prototype for these functions. > Just make them static for now. > > Fixes: 11ecf8c55b91 ("net: phy: broadcom: add cable test support") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Michael Walle <michael@walle.cc> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
From: Michael Walle <michael@walle.cc> Date: Sat, 30 May 2020 22:34:04 +0200 > Don't export __bcm_phy_enable_rdb_access() and > __bcm_phy_enable_legacy_access() functions. They aren't used outside this > module and it was forgotten to provide a prototype for these functions. > Just make them static for now. > > Fixes: 11ecf8c55b91 ("net: phy: broadcom: add cable test support") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Michael Walle <michael@walle.cc> Applied.
diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c index cb92786e3ded..ef6825b30323 100644 --- a/drivers/net/phy/bcm-phy-lib.c +++ b/drivers/net/phy/bcm-phy-lib.c @@ -583,18 +583,16 @@ int bcm_phy_enable_jumbo(struct phy_device *phydev) } EXPORT_SYMBOL_GPL(bcm_phy_enable_jumbo); -int __bcm_phy_enable_rdb_access(struct phy_device *phydev) +static int __bcm_phy_enable_rdb_access(struct phy_device *phydev) { return __bcm_phy_write_exp(phydev, BCM54XX_EXP_REG7E, 0); } -EXPORT_SYMBOL_GPL(__bcm_phy_enable_rdb_access); -int __bcm_phy_enable_legacy_access(struct phy_device *phydev) +static int __bcm_phy_enable_legacy_access(struct phy_device *phydev) { return __bcm_phy_write_rdb(phydev, BCM54XX_RDB_REG0087, BCM54XX_ACCESS_MODE_LEGACY_EN); } -EXPORT_SYMBOL_GPL(__bcm_phy_enable_legacy_access); static int _bcm_phy_cable_test_start(struct phy_device *phydev, bool is_rdb) {
Don't export __bcm_phy_enable_rdb_access() and __bcm_phy_enable_legacy_access() functions. They aren't used outside this module and it was forgotten to provide a prototype for these functions. Just make them static for now. Fixes: 11ecf8c55b91 ("net: phy: broadcom: add cable test support") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Michael Walle <michael@walle.cc> --- Hi, this patch contains a Fixes tag, but is sent to the net-next because the commit which is fixed is only in net-next. -michael drivers/net/phy/bcm-phy-lib.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)