Message ID | 20200528015426.8285-1-doshir@vmware.com |
---|---|
Headers | show |
Series | vmxnet3: upgrade to version 4 | expand |
From: Ronak Doshi <doshir@vmware.com> Date: Wed, 27 May 2020 18:54:22 -0700 > vmxnet3 emulation has recently added several new features which includes > offload support for tunnel packets, support for new commands the driver > can issue to emulation, change in descriptor fields, etc. This patch > series extends the vmxnet3 driver to leverage these new features. > > Compatibility is maintained using existing vmxnet3 versioning mechanism as > follows: > - new features added to vmxnet3 emulation are associated with new vmxnet3 > version viz. vmxnet3 version 4. > - emulation advertises all the versions it supports to the driver. > - during initialization, vmxnet3 driver picks the highest version number > supported by both the emulation and the driver and configures emulation > to run at that version. ... Series applied, thank you.
From: David Miller <davem@davemloft.net> Date: Thu, 28 May 2020 11:07:46 -0700 (PDT) > Series applied, thank you. This doesn't even compile successfully, reverted... :( drivers/net/vmxnet3/vmxnet3_drv.c: In function ‘vmxnet3_tq_xmit’: drivers/net/vmxnet3/vmxnet3_drv.c:1145:5: error: expected ‘}’ before ‘else’ 1145 | } else { | ^~~~ drivers/net/vmxnet3/vmxnet3_ethtool.c: In function ‘vmxnet3_get_rss_hash_opts’: drivers/net/vmxnet3/vmxnet3_ethtool.c:744:6: warning: this statement may fall through [-Wimplicit-fallthrough=] 744 | if (rss_fields & VMXNET3_RSS_FIELDS_ESPIP4) | ^ drivers/net/vmxnet3/vmxnet3_ethtool.c:746:2: note: here 746 | case SCTP_V4_FLOW: | ^~~~ make[3]: *** [scripts/Makefile.build:267: drivers/net/vmxnet3/vmxnet3_drv.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [scripts/Makefile.build:488: drivers/net/vmxnet3] Error 2 make[1]: *** [scripts/Makefile.build:488: drivers/net] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1729: drivers] Error 2