Message ID | 20200515145311.1580134-8-thierry.reding@gmail.com |
---|---|
State | New |
Headers | show |
Series | tegra: Changes for v5.8-rc1 | expand |
On Fri, May 15, 2020 at 4:53 PM Thierry Reding <thierry.reding@gmail.com> wrote: > > ---------------------------------------------------------------- > memory: tegra: Changes for v5.8-rc1 > > Contains a few cleanup patches and an implementation to scale the EMC > frequency on Tegra210 systems. I don't mind taking the memory driver patches, but it seems odd that this pull request has so many drivers/clk changes but does not mention that in the pull request, and does not Cc the clk maintainers or include Acks from them. I would assume that the reason for this is that you have based the memory controller changes on a branch that was already accepted by the clk maintainers in to their tree, but when you do that please be more explicit so I know what is going on. Waiting for clarification before I can pull this. Arnd > Dmitry Osipenko (9): > dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30 > clk: tegra: Add custom CCLK implementation > clk: tegra: pll: Add pre/post rate-change hooks > clk: tegra: cclk: Add helpers for handling PLLX rate changes > clk: tegra20: Use custom CCLK implementation > clk: tegra30: Use custom CCLK implementation > Joseph Lo (7): > dt-bindings: memory: tegra: Add external memory controller binding for Tegra210 > clk: tegra: Add PLLP_UD and PLLMB_UD for Tegra210 > clk: tegra: Export functions for EMC clock scaling > clk: tegra: Implement Tegra210 EMC clock > clk: tegra: Remove the old emc_mux clock for Tegra210
On Mon, May 25, 2020 at 11:52:30PM +0200, Arnd Bergmann wrote: > On Fri, May 15, 2020 at 4:53 PM Thierry Reding <thierry.reding@gmail.com> wrote: > > > > > ---------------------------------------------------------------- > > memory: tegra: Changes for v5.8-rc1 > > > > Contains a few cleanup patches and an implementation to scale the EMC > > frequency on Tegra210 systems. > > I don't mind taking the memory driver patches, but it seems odd that this > pull request has so many drivers/clk changes but does not mention that > in the pull request, and does not Cc the clk maintainers or include Acks > from them. > > I would assume that the reason for this is that you have based > the memory controller changes on a branch that was already > accepted by the clk maintainers in to their tree, but when you do that > please be more explicit so I know what is going on. So historically there's often a lot of dependencies, either build-time or runtime, between Tegra clock patches and other work. That's why we ended up with this model where I collect Tegra clock patches in the Tegra tree and it's not uncommon to end up with the clock branch being a dependency of one of the other branches. I did send this to Mike and Stephen about 1 1/2 weeks ago, but it does not look like they've pulled it into the clk tree yet. I typically highlight the dependencies in the pull request, but looks like I forgot to do that this time around. > Waiting for clarification before I can pull this. Given the above, might be best to hold off on this for a bit until the clock branch was pulled by Mike or Stephen. Thierry
Quoting Thierry Reding (2020-05-26 04:40:54) > On Mon, May 25, 2020 at 11:52:30PM +0200, Arnd Bergmann wrote: > > > Waiting for clarification before I can pull this. > > Given the above, might be best to hold off on this for a bit until the > clock branch was pulled by Mike or Stephen. > I pulled the clk branch into clk-next now.
On Tue, May 26, 2020 at 03:12:10PM -0700, Stephen Boyd wrote: > Quoting Thierry Reding (2020-05-26 04:40:54) > > On Mon, May 25, 2020 at 11:52:30PM +0200, Arnd Bergmann wrote: > > > > > Waiting for clarification before I can pull this. > > > > Given the above, might be best to hold off on this for a bit until the > > clock branch was pulled by Mike or Stephen. > > > > I pulled the clk branch into clk-next now. Hi Arnd, looks like this pull request didn't make it into v5.8-rc1. Was there anything left here that you're waiting for me to address? Thierry