mbox series

[v2,0/2] sensors: occ: Couple of fixes

Message ID 1587999401-3719-1-git-send-email-ego@linux.vnet.ibm.com
Headers show
Series sensors: occ: Couple of fixes | expand

Message

Gautham R Shenoy April 27, 2020, 2:56 p.m. UTC 
From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>

Hi,


This is the v2 of the series containining a couple of fixes for the
occ-sensors code.

1) Fixes the GPU detection code to ensure that systems which have
   NVLink but no GPUs do not expose the GPU sensors.

2) Fixes a bug due to which sensors whose values were 0 were being
reported incorrectly.

v1 (which got posted twice) can be found here:
https://lists.ozlabs.org/pipermail/skiboot/2020-April/016805.html
https://lists.ozlabs.org/pipermail/skiboot/2020-April/016802.html

The change from v1 --> v2 :
In the Patch "sensors: occ: Fix the GPU detection code", fixed the
max_gpus_per_chip to 3 (it was 2 in the earlier patch) as specified in
Section 11.1 of the "OPAL-OCC Shared Memory Interface" of the Version
0.24 of "OCC Firmware Interface Specification for POWER9"


Frederic, Vaidy,

Since the aforementioned change is a minor one, I have retained your
respective "Reviewed-by"s for this patch from v1. Please let me know
if this should be otherwise.


Gautham R. Shenoy (2):
  sensors: occ: Fix the GPU detection code
  sensors: occ: Fix a bug when sensor values are zero

 hw/occ-sensor.c | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

Comments

Oliver O'Halloran May 26, 2020, 7:09 a.m. UTC | #1 
On Tue, Apr 28, 2020 at 1:09 AM Gautham R. Shenoy
<ego@linux.vnet.ibm.com> wrote:
>
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> Hi,
>
>
> This is the v2 of the series containining a couple of fixes for the
> occ-sensors code.
>
> 1) Fixes the GPU detection code to ensure that systems which have
>    NVLink but no GPUs do not expose the GPU sensors.
>
> 2) Fixes a bug due to which sensors whose values were 0 were being
> reported incorrectly.
>
> v1 (which got posted twice) can be found here:
> https://lists.ozlabs.org/pipermail/skiboot/2020-April/016805.html
> https://lists.ozlabs.org/pipermail/skiboot/2020-April/016802.html
>
> The change from v1 --> v2 :
> In the Patch "sensors: occ: Fix the GPU detection code", fixed the
> max_gpus_per_chip to 3 (it was 2 in the earlier patch) as specified in
> Section 11.1 of the "OPAL-OCC Shared Memory Interface" of the Version
> 0.24 of "OCC Firmware Interface Specification for POWER9"

Thanks, series merged as of f3ac046b386fea80286c72c3217acb407230a8c6