Message ID | 20200522122534.3353-2-dmurphy@ti.com |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | RGMII Internal delay common property | expand |
On Fri, May 22, 2020 at 07:25:31AM -0500, Dan Murphy wrote: > tx-internal-delays and rx-internal-delays are a common setting for RGMII > capable devices. > > These properties are used when the phy-mode or phy-controller is set to > rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the > controller that the PHY will add the internal delay for the connection. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v2 - updated to add -ps > > .../bindings/net/ethernet-controller.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index ac471b60ed6a..70702a4ef5e8 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -143,6 +143,20 @@ properties: > Specifies the PHY management type. If auto is set and fixed-link > is not specified, it uses MDIO for management. > > + rx-internal-delay-ps: > + $ref: /schemas/types.yaml#definitions/uint32 > + description: | > + RGMII Receive PHY Clock Delay defined in pico seconds. This is used for > + PHY's that have configurable RX internal delays. This property is only > + used when the phy-mode or phy-connection-type is rgmii-id or rgmii-rxid. Hi Dan Please add a comment about rounding to the nearest supported value. Andrew
diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml index ac471b60ed6a..70702a4ef5e8 100644 --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml @@ -143,6 +143,20 @@ properties: Specifies the PHY management type. If auto is set and fixed-link is not specified, it uses MDIO for management. + rx-internal-delay-ps: + $ref: /schemas/types.yaml#definitions/uint32 + description: | + RGMII Receive PHY Clock Delay defined in pico seconds. This is used for + PHY's that have configurable RX internal delays. This property is only + used when the phy-mode or phy-connection-type is rgmii-id or rgmii-rxid. + + tx-internal-delay-ps: + $ref: /schemas/types.yaml#definitions/uint32 + description: | + RGMII Transmit PHY Clock Delay defined in pico seconds. This is used for + PHY's that have configurable TX internal delays. This property is only + used when the phy-mode or phy-connection-type is rgmii-id or rgmii-txid. + fixed-link: allOf: - if:
tx-internal-delays and rx-internal-delays are a common setting for RGMII capable devices. These properties are used when the phy-mode or phy-controller is set to rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the controller that the PHY will add the internal delay for the connection. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- v2 - updated to add -ps .../bindings/net/ethernet-controller.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)