Message ID | 1589964104-9941-1-git-send-email-vfedorenko@novek.ru |
---|---|
Headers | show |
Series | net/tls: fix encryption error path | expand |
On Wed, 20 May 2020 11:41:42 +0300 Vadim Fedorenko wrote: > The problem with data stream corruption was found in KTLS > transmit path with small socket send buffers and large > amount of data. bpf_exec_tx_verdict() frees open record > on any type of error including EAGAIN, ENOMEM and ENOSPC > while callers are able to recover this transient errors. > Also wrong error code was returned to user space in that > case. This patchset fixes the problems. Thanks: Acked-by: Jakub Kicinski <kuba@kernel.org> Pooja, I think Vadim's fix to check the socket error will make changes to handling of -EAGAIN unnecessary, right? Still would be good to get that selftest, triggering EAGAIN should be quite simple.
On Wed, May 20, 2020 at 4:46 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Wed, 20 May 2020 11:41:42 +0300 Vadim Fedorenko wrote: > > The problem with data stream corruption was found in KTLS > > transmit path with small socket send buffers and large > > amount of data. bpf_exec_tx_verdict() frees open record > > on any type of error including EAGAIN, ENOMEM and ENOSPC > > while callers are able to recover this transient errors. > > Also wrong error code was returned to user space in that > > case. This patchset fixes the problems. > > Thanks: > > Acked-by: Jakub Kicinski <kuba@kernel.org> > > Pooja, I think Vadim's fix to check the socket error will make changes > to handling of -EAGAIN unnecessary, right? Correct, yes. > Still would be good to get > that selftest, triggering EAGAIN should be quite simple. Agree.
From: Vadim Fedorenko <vfedorenko@novek.ru> Date: Wed, 20 May 2020 11:41:42 +0300 > The problem with data stream corruption was found in KTLS > transmit path with small socket send buffers and large > amount of data. bpf_exec_tx_verdict() frees open record > on any type of error including EAGAIN, ENOMEM and ENOSPC > while callers are able to recover this transient errors. > Also wrong error code was returned to user space in that > case. This patchset fixes the problems. Series applied, thanks.