Message ID | 20200509090456.3496481-14-jacopo@jmondi.org |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | [v11,01/13] dt-bindings: video-interfaces: Document 'orientation' property | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 9 errors, 0 warnings, 15 lines checked |
On 09/05/2020 11:04, Jacopo Mondi wrote: > Add a DT header file to contain definitions for standard media properties. > > The file is named after: > Documentation/devicetree/bindings/media/video-interfaces.txt > which contains the standard media properties definitions. > > Initially add three macros to define the supported 'orientation' > property values. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > > I currently don't have users in mainline for this, I understand this implies > this is probably not going to be accepted. At the same time we don't have a > common place for media-related definitions, which support properties defined in > video-interfaces.txt > > I leave it here at the end of the series for discussions, but I'm fine dropping > it from the series. > > Thanks > j > > --- > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 include/dt-bindings/media/video-interfaces.h > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h > new file mode 100644 > index 0000000000000..404c697d6bd6e > --- /dev/null > +++ b/include/dt-bindings/media/video-interfaces.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * include/dt-bindings/media/video-interfaces.h > + * > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> > + */ > + > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > + > +#define FRONT_CAMERA <0> > +#define BACK_CAMERA <1> > +#define EXTERNAL_CAMERA <2> Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ? I'm skipping this patch for the PR. Regards, Hans > + > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ > -- > 2.26.1 >
On Sat, May 09, 2020 at 11:04:56AM +0200, Jacopo Mondi wrote: > Add a DT header file to contain definitions for standard media properties. > > The file is named after: > Documentation/devicetree/bindings/media/video-interfaces.txt > which contains the standard media properties definitions. > > Initially add three macros to define the supported 'orientation' > property values. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > > I currently don't have users in mainline for this, I understand this implies > this is probably not going to be accepted. At the same time we don't have a > common place for media-related definitions, which support properties defined in > video-interfaces.txt Fine for me with no users if values already defined in binding. > > I leave it here at the end of the series for discussions, but I'm fine dropping > it from the series. > > Thanks > j > > --- > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 include/dt-bindings/media/video-interfaces.h > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h > new file mode 100644 > index 0000000000000..404c697d6bd6e > --- /dev/null > +++ b/include/dt-bindings/media/video-interfaces.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ Dual license please. > +/* > + * include/dt-bindings/media/video-interfaces.h > + * > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> > + */ > + > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > + > +#define FRONT_CAMERA <0> > +#define BACK_CAMERA <1> > +#define EXTERNAL_CAMERA <2> > + > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ > -- > 2.26.1 >
Hi Hans, On Mon, May 11, 2020 at 09:27:57AM +0200, Hans Verkuil wrote: > On 09/05/2020 11:04, Jacopo Mondi wrote: > > Add a DT header file to contain definitions for standard media properties. > > > > The file is named after: > > Documentation/devicetree/bindings/media/video-interfaces.txt > > which contains the standard media properties definitions. > > > > Initially add three macros to define the supported 'orientation' > > property values. > > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > > > I currently don't have users in mainline for this, I understand this implies > > this is probably not going to be accepted. At the same time we don't have a > > common place for media-related definitions, which support properties defined in > > video-interfaces.txt > > > > I leave it here at the end of the series for discussions, but I'm fine dropping > > it from the series. > > > > Thanks > > j > > > > --- > > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > create mode 100644 include/dt-bindings/media/video-interfaces.h > > > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h > > new file mode 100644 > > index 0000000000000..404c697d6bd6e > > --- /dev/null > > +++ b/include/dt-bindings/media/video-interfaces.h > > @@ -0,0 +1,15 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * include/dt-bindings/media/video-interfaces.h > > + * > > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> > > + */ > > + > > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ > > + > > +#define FRONT_CAMERA <0> > > +#define BACK_CAMERA <1> > > +#define EXTERNAL_CAMERA <2> > > Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ? I used that notation to be able to write orientation = FRONT_CAMERA in place of orientation = <FRONT_CAMERA> Do you think it's wrong ? Thanks j > > I'm skipping this patch for the PR. > > Regards, > > Hans > > > + > > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ > > -- > > 2.26.1 > > >
On 20/05/2020 09:52, Jacopo Mondi wrote: > Hi Hans, > > On Mon, May 11, 2020 at 09:27:57AM +0200, Hans Verkuil wrote: >> On 09/05/2020 11:04, Jacopo Mondi wrote: >>> Add a DT header file to contain definitions for standard media properties. >>> >>> The file is named after: >>> Documentation/devicetree/bindings/media/video-interfaces.txt >>> which contains the standard media properties definitions. >>> >>> Initially add three macros to define the supported 'orientation' >>> property values. >>> >>> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> >>> --- >>> >>> I currently don't have users in mainline for this, I understand this implies >>> this is probably not going to be accepted. At the same time we don't have a >>> common place for media-related definitions, which support properties defined in >>> video-interfaces.txt >>> >>> I leave it here at the end of the series for discussions, but I'm fine dropping >>> it from the series. >>> >>> Thanks >>> j >>> >>> --- >>> include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> create mode 100644 include/dt-bindings/media/video-interfaces.h >>> >>> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h >>> new file mode 100644 >>> index 0000000000000..404c697d6bd6e >>> --- /dev/null >>> +++ b/include/dt-bindings/media/video-interfaces.h >>> @@ -0,0 +1,15 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +/* >>> + * include/dt-bindings/media/video-interfaces.h >>> + * >>> + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> >>> + */ >>> + >>> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ >>> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ >>> + >>> +#define FRONT_CAMERA <0> >>> +#define BACK_CAMERA <1> >>> +#define EXTERNAL_CAMERA <2> >> >> Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ? > > I used that notation to be able to write > orientation = FRONT_CAMERA > in place of > orientation = <FRONT_CAMERA> > > Do you think it's wrong ? Yes, I think that's wrong :-) From what I can see in existing device tree files you do not hide the '<>'. Regards, Hans > > Thanks > j > >> >> I'm skipping this patch for the PR. >> >> Regards, >> >> Hans >> >>> + >>> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */ >>> -- >>> 2.26.1 >>> >>
diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h new file mode 100644 index 0000000000000..404c697d6bd6e --- /dev/null +++ b/include/dt-bindings/media/video-interfaces.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * include/dt-bindings/media/video-interfaces.h + * + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org> + */ + +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ + +#define FRONT_CAMERA <0> +#define BACK_CAMERA <1> +#define EXTERNAL_CAMERA <2> + +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
Add a DT header file to contain definitions for standard media properties. The file is named after: Documentation/devicetree/bindings/media/video-interfaces.txt which contains the standard media properties definitions. Initially add three macros to define the supported 'orientation' property values. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- I currently don't have users in mainline for this, I understand this implies this is probably not going to be accepted. At the same time we don't have a common place for media-related definitions, which support properties defined in video-interfaces.txt I leave it here at the end of the series for discussions, but I'm fine dropping it from the series. Thanks j --- include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 include/dt-bindings/media/video-interfaces.h -- 2.26.1