| Message ID | 20200518130415.54668-1-linus.walleij@linaro.org |
|---|---|
| State | Rejected |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | [OpenWrt-Devel] gemini: Add samba4 to the NAS images | expand |
Linus Walleij <linus.walleij@linaro.org> [2020-05-18 15:04:15]: Hi, > We used to have samba36 as a package in the NAS images but that was retired > in commit 73fa1aba94f5 "samba36: Remove" however it is nice to have a > fileserver so put samba4 in the package instead. this is going to end with the build failure on the snapshot buildbot as samba4 package is not available in the tree, it's availabe from packages feed repo. -- ynezz
On 18.05.2020 16:04, Linus Walleij wrote: > We used to have samba36 as a package in the NAS images > but that was retired in commit 73fa1aba94f5 > "samba36: Remove" however it is nice to have a fileserver > so put samba4 in the package instead. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > target/linux/gemini/image/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/linux/gemini/image/Makefile b/target/linux/gemini/image/Makefile > index a155939b8cd6..17e07897af04 100644 > --- a/target/linux/gemini/image/Makefile > +++ b/target/linux/gemini/image/Makefile > @@ -141,7 +141,7 @@ GEMINI_NAS_PACKAGES := $(DEFAULT_PACKAGES.nas) \ > kmod-fs-btrfs kmod-fs-cifs kmod-fs-nfs \ > kmod-fs-nfsd kmod-fs-ntfs kmod-fs-reiserfs kmod-fs-vfat \ > kmod-nls-utf8 kmod-usb-storage-extras kmod-hwmon-drivetemp \ > - cfdisk e2fsprogs badblocks \ > + cfdisk e2fsprogs badblocks samba4-server \ > partx-utils > > # The DIR-685 flash layout is kernel in WRGG format, padded and followed Hi, samba4 is not in the main repo and there was an attempt for ksmbd-tools to be ported on main repo, it's faster and smaller Regards
On Mon, May 18, 2020 at 3:27 PM Petr Štetiar <ynezz@true.cz> wrote: > Linus Walleij <linus.walleij@linaro.org> [2020-05-18 15:04:15]: > > > We used to have samba36 as a package in the NAS images but that was retired > > in commit 73fa1aba94f5 "samba36: Remove" however it is nice to have a > > fileserver so put samba4 in the package instead. > > this is going to end with the build failure on the snapshot buildbot as samba4 > package is not available in the tree, it's availabe from packages feed repo. Ah I see, makes sense. Let's drop this. Yours, Linus Walleij
diff --git a/target/linux/gemini/image/Makefile b/target/linux/gemini/image/Makefile index a155939b8cd6..17e07897af04 100644 --- a/target/linux/gemini/image/Makefile +++ b/target/linux/gemini/image/Makefile @@ -141,7 +141,7 @@ GEMINI_NAS_PACKAGES := $(DEFAULT_PACKAGES.nas) \ kmod-fs-btrfs kmod-fs-cifs kmod-fs-nfs \ kmod-fs-nfsd kmod-fs-ntfs kmod-fs-reiserfs kmod-fs-vfat \ kmod-nls-utf8 kmod-usb-storage-extras kmod-hwmon-drivetemp \ - cfdisk e2fsprogs badblocks \ + cfdisk e2fsprogs badblocks samba4-server \ partx-utils # The DIR-685 flash layout is kernel in WRGG format, padded and followed
We used to have samba36 as a package in the NAS images but that was retired in commit 73fa1aba94f5 "samba36: Remove" however it is nice to have a fileserver so put samba4 in the package instead. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- target/linux/gemini/image/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)