| Message ID | 20200515212846.1347-16-mcgrof@kernel.org |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: taint when the device driver firmware crashes | expand |
On Fri, May 15, 2020 at 09:28:46PM +0000, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: linux-wireless@vger.kernel.org > Cc: Lennert Buytenhek <buytenh@wantstofly.org> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Johannes Berg <johannes.berg@intel.com> > Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > --- > drivers/net/wireless/marvell/mwl8k.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c > index 97f23f93f6e7..d609ef1bb879 100644 > --- a/drivers/net/wireless/marvell/mwl8k.c > +++ b/drivers/net/wireless/marvell/mwl8k.c > @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw) > * the firmware has crashed > */ > if (priv->hw_restart_in_progress) { > + module_firmware_crashed(); > if (priv->hw_restart_owner == current) > return 0; > else > -- > 2.26.2 > Acked-by: Rafael Aquini <aquini@redhat.com>
diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c index 97f23f93f6e7..d609ef1bb879 100644 --- a/drivers/net/wireless/marvell/mwl8k.c +++ b/drivers/net/wireless/marvell/mwl8k.c @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw) * the firmware has crashed */ if (priv->hw_restart_in_progress) { + module_firmware_crashed(); if (priv->hw_restart_owner == current) return 0; else
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: Lennert Buytenhek <buytenh@wantstofly.org> Cc: Kalle Valo <kvalo@codeaurora.org> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Cc: Johannes Berg <johannes.berg@intel.com> Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+)