Message ID | 20110706205525.7E1CC1C3723@gchare.mtv.corp.google.com |
---|---|
State | New |
Headers | show |
On Wed, Jul 6, 2011 at 16:55, Gabriel Charette <gchare@google.com> wrote: > +2011-07-06 Gabriel Charette <gchare@google.com> > + > + * passes.c (rest_of_decl_compilation): Add FIXME pph comment. > + OK under the obvious rule (small patches like this one that make obvious fixes to documentation or formatting or code do not need explicit approval). Diego.
diff --git a/gcc/ChangeLog.pph b/gcc/ChangeLog.pph index b9aeb4d..2776bf0 100644 --- a/gcc/ChangeLog.pph +++ b/gcc/ChangeLog.pph @@ -1,3 +1,7 @@ +2011-07-06 Gabriel Charette <gchare@google.com> + + * passes.c (rest_of_decl_compilation): Add FIXME pph comment. + 2011-07-05 Diego Novillo <dnovillo@google.com> Merge from trunk rev 175832. diff --git a/gcc/passes.c b/gcc/passes.c index fc9767e..ce7f846 100644 --- a/gcc/passes.c +++ b/gcc/passes.c @@ -184,7 +184,9 @@ rest_of_decl_compilation (tree decl, && !DECL_EXTERNAL (decl)) { /* When reading LTO unit, we also read varpool, so do not - rebuild it. */ + rebuild it. + FIXME pph: This is also true for pph and we should not + call varpool_finalize_decl when generating a pph image. */ if (in_lto_p && !at_end) ; else if (TREE_CODE (decl) != FUNCTION_DECL)